V3 Playground #701
Draft
V3 Playground #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A layer to the srtp driver test is added to be able to run the tests both in-place & not-in-place without duplicating the test. The not-in-place functions are currently a minimal implementation using a memcpy.
The keystream prefix needs to be placed in auth tag before the auth is calculated. This was done for all protect / unprotect functions except unprotect_rtcp. Now functionality is aligned.
The mki_size member of the srtp_stream_ctx_t has the correct value at all times, no need to manage the value of a separate mke_size variable.
The protect/unprotect api's can now operate both in-place or not in-place, depending on the requirements of the caller. The length of the out buffer can now be checked to ensure there is sufficient space. Tests are add to verify validation of the output buffer length.
They can now be reused in other tests. Switch from err_check to CHECK_OK in srtp_driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A place to make visible and try out various changes that will be proposed for V3.
This PR will not be merged in in to main, but commits from this PR might be moved out to new PR's when they are ready for review & merging.
Note: the commit history of this branch will be rewritten often