Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIRC-9456 - Implicit Tag Support #833

Open
wants to merge 43 commits into
base: master
Choose a base branch
from

Commits on Jun 20, 2023

  1. Configuration menu
    Copy the full SHA
    e57418e View commit details
    Browse the repository at this point in the history
  2. rework & testing

    keep code as DRY as possible without changing public API signatures by only maintaining one function, `add_tags_to_tagset_builder`, that can add either one or many tags to a tagset.
    
    the `add_one` and `add many` endpoints have the same behavior, but are kept as separate functions to prevent altering function signatures.
    
    allow optionally getting canonical name when using `noit_metric_add_implicit_tags_to_tagset`.
    
    add tests for implicit tags.
    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    2da45c6 View commit details
    Browse the repository at this point in the history
  3. fix bug preventing adding tags to existing tagset due to inability to…

    … realloc memory that was never allocated with malloc
    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    a8c8f00 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dbfaf75 View commit details
    Browse the repository at this point in the history
  5. test el7 failure

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    bfbe5f0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f4a5653 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3ee3273 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d6ea76b View commit details
    Browse the repository at this point in the history
  9. update makefile

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9818ad2 View commit details
    Browse the repository at this point in the history
  10. review

    calloc instead of malloc.
    
    free `stags` and `mtags` since they are initialized with calloc.
    
    should not use `mtev_dyn_buffer_size` because the return is double the actul size we intent to use. use the value used to ensure the size instead.
    
    should not use `mtev_dyn_buffer_used` when modifying the buffer through noit functions instead of buffer functions because return will be inacurate.
    
    use `size_t` insted of `int32_t`.
    
    use `mtev_dyn_buffer_data` instead of creating new pointer.
    
    use const.
    
    clean up tests and assert the expected tag pair sizes.
    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    673dcf3 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6c793aa View commit details
    Browse the repository at this point in the history
  12. use NOIT_METRIC_TAGSET_CHECK for hook so snowth's `check_tag_tagset…

    …_completer` checks for `__check_uuid`.
    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    bd1a402 View commit details
    Browse the repository at this point in the history
  13. update test

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    f92847d View commit details
    Browse the repository at this point in the history
  14. keep string around

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    7022bc4 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    d01f772 View commit details
    Browse the repository at this point in the history
  16. const

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9d42dd3 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    0b219f8 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    aec6bb7 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    506fad4 View commit details
    Browse the repository at this point in the history
  20. fix testing leaks

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ee46b9f View commit details
    Browse the repository at this point in the history
  21. fix seg fault

    properly initialize tagset
    
    `tagset_implicit->tags` was being set through `MKTAGSETCOPY`. we do not need to copy the tags for `tagset_implicit` because it is an empty set and we are not using anything from `id` that could be changed.
    
    use `calloc` if memory has not been allocated already.
    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    823df65 View commit details
    Browse the repository at this point in the history
  22. formatting

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    5b14a1f View commit details
    Browse the repository at this point in the history
  23. noit_metric_tag_t must have their members copied individually.

    .tag needs to be given it's own memory block so that it persists in the tagset after the input goes out of scope.
    
    +1 to add a null terminator
    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    8ecc00a View commit details
    Browse the repository at this point in the history
  24. use parsed_tag_count instead of tag_count in case they differ.

    the previous realloc was always for the same size that we just calloced.
    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    d0da8df View commit details
    Browse the repository at this point in the history
  25. cast char* to void*

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9ebf3e8 View commit details
    Browse the repository at this point in the history
  26. Revert "cast char* to void*"

    This reverts commit 2787251.
    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    5922d6e View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    839fcdd View commit details
    Browse the repository at this point in the history
  28. formatting

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9ede60f View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    ca5d1f8 View commit details
    Browse the repository at this point in the history
  30. don't init out arg

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    43ea246 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    62fb17f View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    f3b38f0 View commit details
    Browse the repository at this point in the history
  33. properly init tagsets

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    bd7fedd View commit details
    Browse the repository at this point in the history
  34. const

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0b01bd4 View commit details
    Browse the repository at this point in the history
  35. use fmt::format

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    82d4c48 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    40663c3 View commit details
    Browse the repository at this point in the history
  37. avoid needing to define an additional value for `noit_metric_tagset_c…

    …lass_t`.
    
    add implicit tags to existing tagsets, but increase the max size to allow for them.
    
    we can increase the max size because these tagsets are copied locally and the extended size does not conflict with the functions performed on the tagset in this scope.
    
    since it is a copy, the implicit tags are not being added to the id's actual check and stream tags.
    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    aa29143 View commit details
    Browse the repository at this point in the history
  38. +1 to ensured length to account for for colon added to cat-only tags

    no need to get the encode(decode) length because they are inverse operations
    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    303a7cd View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    13b7ea7 View commit details
    Browse the repository at this point in the history
  40. dynamically allocate memory

    this fixes a segfault when attempting to realloc this memory later.
    this also allows us to allocate only the necessary memory instead of the max.
    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    1a4e727 View commit details
    Browse the repository at this point in the history
  41. free calloced memory

    RobBoeckermann committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    00c6540 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    4efaf6d View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Configuration menu
    Copy the full SHA
    ae0990a View commit details
    Browse the repository at this point in the history