-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIRC-9456 - Implicit Tag Support #833
base: master
Are you sure you want to change the base?
Commits on Jun 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e57418e - Browse repository at this point
Copy the full SHA e57418eView commit details -
keep code as DRY as possible without changing public API signatures by only maintaining one function, `add_tags_to_tagset_builder`, that can add either one or many tags to a tagset. the `add_one` and `add many` endpoints have the same behavior, but are kept as separate functions to prevent altering function signatures. allow optionally getting canonical name when using `noit_metric_add_implicit_tags_to_tagset`. add tests for implicit tags.
Configuration menu - View commit details
-
Copy full SHA for 2da45c6 - Browse repository at this point
Copy the full SHA 2da45c6View commit details -
fix bug preventing adding tags to existing tagset due to inability to…
… realloc memory that was never allocated with malloc
Configuration menu - View commit details
-
Copy full SHA for a8c8f00 - Browse repository at this point
Copy the full SHA a8c8f00View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbfaf75 - Browse repository at this point
Copy the full SHA dbfaf75View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfbe5f0 - Browse repository at this point
Copy the full SHA bfbe5f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4a5653 - Browse repository at this point
Copy the full SHA f4a5653View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ee3273 - Browse repository at this point
Copy the full SHA 3ee3273View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6ea76b - Browse repository at this point
Copy the full SHA d6ea76bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9818ad2 - Browse repository at this point
Copy the full SHA 9818ad2View commit details -
calloc instead of malloc. free `stags` and `mtags` since they are initialized with calloc. should not use `mtev_dyn_buffer_size` because the return is double the actul size we intent to use. use the value used to ensure the size instead. should not use `mtev_dyn_buffer_used` when modifying the buffer through noit functions instead of buffer functions because return will be inacurate. use `size_t` insted of `int32_t`. use `mtev_dyn_buffer_data` instead of creating new pointer. use const. clean up tests and assert the expected tag pair sizes.
Configuration menu - View commit details
-
Copy full SHA for 673dcf3 - Browse repository at this point
Copy the full SHA 673dcf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c793aa - Browse repository at this point
Copy the full SHA 6c793aaView commit details -
use
NOIT_METRIC_TAGSET_CHECK
for hook so snowth's `check_tag_tagset……_completer` checks for `__check_uuid`.
Configuration menu - View commit details
-
Copy full SHA for bd1a402 - Browse repository at this point
Copy the full SHA bd1a402View commit details -
Configuration menu - View commit details
-
Copy full SHA for f92847d - Browse repository at this point
Copy the full SHA f92847dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7022bc4 - Browse repository at this point
Copy the full SHA 7022bc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d01f772 - Browse repository at this point
Copy the full SHA d01f772View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d42dd3 - Browse repository at this point
Copy the full SHA 9d42dd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b219f8 - Browse repository at this point
Copy the full SHA 0b219f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for aec6bb7 - Browse repository at this point
Copy the full SHA aec6bb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 506fad4 - Browse repository at this point
Copy the full SHA 506fad4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee46b9f - Browse repository at this point
Copy the full SHA ee46b9fView commit details -
properly initialize tagset `tagset_implicit->tags` was being set through `MKTAGSETCOPY`. we do not need to copy the tags for `tagset_implicit` because it is an empty set and we are not using anything from `id` that could be changed. use `calloc` if memory has not been allocated already.
Configuration menu - View commit details
-
Copy full SHA for 823df65 - Browse repository at this point
Copy the full SHA 823df65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b14a1f - Browse repository at this point
Copy the full SHA 5b14a1fView commit details -
noit_metric_tag_t must have their members copied individually.
.tag needs to be given it's own memory block so that it persists in the tagset after the input goes out of scope. +1 to add a null terminator
Configuration menu - View commit details
-
Copy full SHA for 8ecc00a - Browse repository at this point
Copy the full SHA 8ecc00aView commit details -
use
parsed_tag_count
instead oftag_count
in case they differ.the previous realloc was always for the same size that we just calloced.
Configuration menu - View commit details
-
Copy full SHA for d0da8df - Browse repository at this point
Copy the full SHA d0da8dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ebf3e8 - Browse repository at this point
Copy the full SHA 9ebf3e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5922d6e - Browse repository at this point
Copy the full SHA 5922d6eView commit details -
Revert "noit_metric_tag_t must have their members copied individually."
This reverts commit 36f9db3.
Configuration menu - View commit details
-
Copy full SHA for 839fcdd - Browse repository at this point
Copy the full SHA 839fcddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ede60f - Browse repository at this point
Copy the full SHA 9ede60fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca5d1f8 - Browse repository at this point
Copy the full SHA ca5d1f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43ea246 - Browse repository at this point
Copy the full SHA 43ea246View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62fb17f - Browse repository at this point
Copy the full SHA 62fb17fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3b38f0 - Browse repository at this point
Copy the full SHA f3b38f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd7fedd - Browse repository at this point
Copy the full SHA bd7feddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b01bd4 - Browse repository at this point
Copy the full SHA 0b01bd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82d4c48 - Browse repository at this point
Copy the full SHA 82d4c48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40663c3 - Browse repository at this point
Copy the full SHA 40663c3View commit details -
avoid needing to define an additional value for `noit_metric_tagset_c…
…lass_t`. add implicit tags to existing tagsets, but increase the max size to allow for them. we can increase the max size because these tagsets are copied locally and the extended size does not conflict with the functions performed on the tagset in this scope. since it is a copy, the implicit tags are not being added to the id's actual check and stream tags.
Configuration menu - View commit details
-
Copy full SHA for aa29143 - Browse repository at this point
Copy the full SHA aa29143View commit details -
+1 to ensured length to account for for colon added to cat-only tags
no need to get the encode(decode) length because they are inverse operations
Configuration menu - View commit details
-
Copy full SHA for 303a7cd - Browse repository at this point
Copy the full SHA 303a7cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13b7ea7 - Browse repository at this point
Copy the full SHA 13b7ea7View commit details -
this fixes a segfault when attempting to realloc this memory later. this also allows us to allocate only the necessary memory instead of the max.
Configuration menu - View commit details
-
Copy full SHA for 1a4e727 - Browse repository at this point
Copy the full SHA 1a4e727View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00c6540 - Browse repository at this point
Copy the full SHA 00c6540View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4efaf6d - Browse repository at this point
Copy the full SHA 4efaf6dView commit details
Commits on Jun 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ae0990a - Browse repository at this point
Copy the full SHA ae0990aView commit details