New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DOMHTMLSeasonEpisodesParser Rule with key=_seasons #503
base: master
Are you sure you want to change the base?
Fix DOMHTMLSeasonEpisodesParser Rule with key=_seasons #503
Conversation
it still doens't fully work, if you run the tests it still fails: it can find the selected season 'cause they probably changed a bunch of aria-related things. i've already come up with a working solution though: you should change this line into: extractor=Path('//a[@data-testid="tab-season-entry"][contains(@class, "ipc-tab--active")]/text()') that accounts for the change. more specifically they used the attribute "aria-selected=true" for marking the season you are onto. now the use the class "ipc-tab--active", the |
@topongo I forked his change and updated line 2164 like you said, and I was having issues with seasons.sort(). Not sure if this is relevant to this issue but at least I was able to grab part of a season with the changes |
thanks, I'd do it myself, I just didn't want to make tons of pull requests for just one thing. but seeing the other guy is unresponsive i think it's a good idea. edit: no clue about the sorting issue |
hi @CodeMastr3 and @topongo : unfortunately in the last months I had almost zero time to devote to the project. I'm still willing to do maintenance and help as much as possible and every contribution is welcome. So, please let me know when you are satisfied with the PR and I will merge it. |
@alberanid So I've used both the current branch for the PR and a branch with the change @topongo recommended but I'm not able to see a difference between them with the small change. It would be nice if @mhrashvand1 returned for this PR |
@CodeMastr3 i don't know the history of the web ui nor do i know if a recent change broke many things at once... we should ask @alberanid for this. but we should keep this issues separated imo if @mhrashvand1 won't get in touch in a few days i'll create a new pr |
Any plan to merge this PR and build new release with the fix for series seasons and episodes. |
No description provided.