Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DOMHTMLSeasonEpisodesParser Rule with key=_seasons #503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhrashvand1
Copy link

No description provided.

@topongo
Copy link

topongo commented Mar 11, 2024

it still doens't fully work, if you run the tests it still fails: it can find the selected season 'cause they probably changed a bunch of aria-related things. i've already come up with a working solution though:

you should change this line into:

extractor=Path('//a[@data-testid="tab-season-entry"][contains(@class, "ipc-tab--active")]/text()')

that accounts for the change.

more specifically they used the attribute "aria-selected=true" for marking the season you are onto. now the use the class "ipc-tab--active", the contains funcion is used because XPaths don't account for space separated list (source)

CodeMastr3

This comment was marked as outdated.

@CodeMastr3
Copy link

@topongo I forked his change and updated line 2164 like you said, and I was having issues with seasons.sort(). Not sure if this is relevant to this issue but at least I was able to grab part of a season with the changes

@topongo
Copy link

topongo commented Mar 23, 2024

thanks, I'd do it myself, I just didn't want to make tons of pull requests for just one thing. but seeing the other guy is unresponsive i think it's a good idea.

edit: no clue about the sorting issue

@alberanid
Copy link
Collaborator

hi @CodeMastr3 and @topongo : unfortunately in the last months I had almost zero time to devote to the project.

I'm still willing to do maintenance and help as much as possible and every contribution is welcome. So, please let me know when you are satisfied with the PR and I will merge it.

@CodeMastr3
Copy link

@alberanid So I've used both the current branch for the PR and a branch with the change @topongo recommended but I'm not able to see a difference between them with the small change. It would be nice if @mhrashvand1 returned for this PR
The only thing I know is I'm testing with grabbing One Piece as the series and trying to count all of its episodes but I get back only 50 episodes from season 1 and 11 from season 2 for a total of 61.
I don't know if that is my fault, the fixes fault, or just works this way because on IMDB each series only shows 50 episodes at a time initially

@topongo
Copy link

topongo commented Mar 26, 2024

@CodeMastr3
the problem with the 50 episode limit is a web ui problem, already mentioned in #482 and strictly speaking it's unrelated.

i don't know the history of the web ui nor do i know if a recent change broke many things at once... we should ask @alberanid for this. but we should keep this issues separated imo

if @mhrashvand1 won't get in touch in a few days i'll create a new pr

@markomno
Copy link

Any plan to merge this PR and build new release with the fix for series seasons and episodes.
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants