dev: Update vagrant configuration #2413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to support a bigger vagrant instance locally Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to avoid the below issue, small refactor is also done. ``` vagrant@ubuntu-jammy:~/go/src/github.com/cilium/tetragon$ make test make -C "contrib/tester-progs" make[1]: Entering directory '/home/vagrant/go/src/github.com/cilium/tetragon/contrib/tester-progs' go build -o lseek-pipe ./go/lseek-pipe go: errors parsing go.mod: /home/vagrant/go/src/github.com/cilium/tetragon/go.mod:4: invalid go version '1.22.0': must match format 1.23 make[1]: *** [Makefile:87: lseek-pipe] Error 1 make[1]: Leaving directory '/home/vagrant/go/src/github.com/cilium/tetragon/contrib/tester-progs' make: *** [Makefile:416: tester-progs] Error 2 ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added
the
release-note/misc
jrfastab
reviewed
May 5, 2024
| # Install golang | ||
| GO_VERSION=$1 | ||
| curl -O https://storage.googleapis.com/golang/go$GO_VERSION.linux-amd64.tar.gz && \ | ||
| rm -rf /usr/local/go \ |
There was a problem hiding this comment.
I don't think we want to delete existing go on users. This is on the host?
Could we check if go version is correct first and then give a readable warning with instructions on how to do this? And/or prompt to replace?
mtardy
reviewed
May 16, 2024
There was a problem hiding this comment.
hey, just commenting since I think we don't use Vagrant for any of the CI tests. So it's a development thing I don't think one many people use.
However, I have no objection to merge this since it might be well outdated but it's not well tested and thus not maintained so maybe we could discuss removing it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pleases refer to individual commit for more details.
Testing
Testing was done locally with
make testafter VM provision as per below