New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update module google.golang.org/grpc to v1.63.0 (main) - abandoned #2306
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: cilium-renovate[bot] <134692979+cilium-renovate[bot]@users.noreply.github.com>
2ab4ca0
to
9d136d5
Compare
grpc.DialContext was recently deprecated and replaced with NewClient. The difference with NewClient is that it does not take any context and cannot block until the connection is done. This patch should reproduce the previous behavior by adding an explicit conn.WaitForStageChange after the creation of the client. In some situations, we might not want to wait for the connection to be established and maybe just proceed and fail later, but this patch should hopefully just keep the old behavior in place. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
okay something's off https://github.com/cilium/tetragon/actions/runs/8602579046/job/23572651633?pr=2306 :/ |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
I converted it to draft and removed the release-blocker label because the API change in grpc-go has been postponed apparently. |
This PR contains the following updates:
v1.62.2
->v1.63.0
Release Notes
grpc/grpc-go (google.golang.org/grpc)
v1.63.0
: Release 1.63.0Compare Source
Behavior Changes
resolver.Address.String()
(experimental) (#6923)New Features
ClientConn.CanonicalTarget()
to return the canonical target string. (#7006)grpc.NewClient
to allow users to create new clients in idle mode and with "dns" as the default resolver (#7010)API Changes
ClientConn.Target()
(#7006)Bug Fixes
grpc.Server
as anhttp.Handler
with the Go stdlib HTTP server (#6989)SetResolvingTimeout
to allow configuring the DNS resolver's global timeout (#6917)Configuration
📅 Schedule: Branch creation - "on monday and friday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.