Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module google.golang.org/grpc to v1.63.0 (main) - abandoned #2306

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cilium-renovate[bot]
Copy link
Contributor

@cilium-renovate cilium-renovate bot commented Apr 5, 2024

This PR contains the following updates:

Package Type Update Change
google.golang.org/grpc require minor v1.62.2 -> v1.63.0

Release Notes

grpc/grpc-go (google.golang.org/grpc)

v1.63.0: Release 1.63.0

Compare Source

Behavior Changes

  • grpc: Return canonical target string from resolver.Address.String() (experimental) (#​6923)
  • client & server: when using write buffer pooling, use input value for buffer size instead of size*2 (#​6983)

New Features

  • grpc: add ClientConn.CanonicalTarget() to return the canonical target string. (#​7006)
  • xds: implement LRS named metrics support (gRFC A64) (#​7027)
  • grpc: introduce grpc.NewClient to allow users to create new clients in idle mode and with "dns" as the default resolver (#​7010)

API Changes

  • grpc: stabilize experimental method ClientConn.Target() (#​7006)

Bug Fixes

  • xds: fix an issue that would cause the client to send an empty list of resources for LDS/CDS upon reconnecting with the management server (#​7026)
  • server: Fix some errors returned by a server when using a grpc.Server as an http.Handler with the Go stdlib HTTP server (#​6989)
  • resolver/dns: add SetResolvingTimeout to allow configuring the DNS resolver's global timeout (#​6917)
  • Set the security level of Windows named pipes to NoSecurity (#​6956)

Configuration

📅 Schedule: Branch creation - "on monday and friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@cilium-renovate cilium-renovate bot requested a review from a team as a code owner April 5, 2024 12:13
@cilium-renovate cilium-renovate bot added release-blocker This PR or issue is blocking the next release. release-note/dependency This PR updates one or multiple dependencies labels Apr 5, 2024
@cilium-renovate cilium-renovate bot requested a review from olsajiri April 5, 2024 12:13
Signed-off-by: cilium-renovate[bot] <134692979+cilium-renovate[bot]@users.noreply.github.com>
@cilium-renovate cilium-renovate bot force-pushed the renovate/main-google.golang.org-grpc-1.x branch from 2ab4ca0 to 9d136d5 Compare April 8, 2024 14:11
grpc.DialContext was recently deprecated and replaced with NewClient.
The difference with NewClient is that it does not take any context and
cannot block until the connection is done. This patch should reproduce
the previous behavior by adding an explicit conn.WaitForStageChange
after the creation of the client.

In some situations, we might not want to wait for the connection to be
established and maybe just proceed and fail later, but this patch should
hopefully just keep the old behavior in place.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
@mtardy
Copy link
Member

mtardy commented Apr 8, 2024

@cilium-renovate
Copy link
Contributor Author

cilium-renovate bot commented Apr 8, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@cilium-renovate cilium-renovate bot changed the title fix(deps): update module google.golang.org/grpc to v1.63.0 (main) fix(deps): update module google.golang.org/grpc to v1.63.0 (main) - abandoned Apr 9, 2024
@cilium-renovate
Copy link
Contributor Author

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@lambdanis lambdanis marked this pull request as draft April 26, 2024 13:22
@lambdanis lambdanis removed the release-blocker This PR or issue is blocking the next release. label Apr 26, 2024
@lambdanis
Copy link
Contributor

I converted it to draft and removed the release-blocker label because the API change in grpc-go has been postponed apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/dependency This PR updates one or multiple dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants