Add support to test update library with local kernel #1306
Conversation
There was a problem hiding this comment.
Makes sense, thanks for the PR. Can you also document this in https://github.com/cilium/ebpf/blob/main/docs/ebpf/contributing/index.md#updating-kernel-dependencies ?
| curl -fL "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/plain/tools/lib/bpf/libbpf.c?h=v$KERNEL_VERSION" -o "$tmp/libbpf.c" | ||
| if [ -d $KERNEL_VERSION ]; then | ||
| # Copy libbpf/vmlinux/bpf_testmod from local directory | ||
| cp $KERNEL_VERSION/libbpf.c $tmp |
There was a problem hiding this comment.
Would it make sense to assume that KERNEL_VERSION is a checkout of the linux source? Then you can just run make KERNEL_VERSION=/path/to/linux. Right now you need to copy things around.
There was a problem hiding this comment.
I guess it's possible, but at the moment I have the kernel build on another server, so current change fits me better.. maybe we could introduce more variables to allow that? I felt like the current change is abusing bit the KERNEL_VERSION variable, but it's simple ;-)
There was a problem hiding this comment.
Hm, maybe you can abuse rsync to get transparent copy from your build server? Basically, the usual thing would be to rsync from a local directory, but if you set your variable to user@host:/path/to/linux it'd slurp that over.
I don't much see the point of adding the option in a way that means extra work for the common case to be honest.
There was a problem hiding this comment.
hum, not sure I see enough benefit in doing the rsync.. I don't think the local kernel update will happen that often.. but I'm ok to keep that change around just for my purposes, there's no need for that to be merged if it's a problem
Adding support to update update library with local kernel by passing local directory through KERNEL_VERSION, like: $ ls ../data/ bpf_testmod.ko libbpf.c vmlinux $ make update-kernel-deps KERNEL_VERSION=../data This allows to test latest kernel uapi changes with ebpf/cilium library and tetragon. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
local_kernel_update
branch
from
945cfba
to
804a455
Compare
Adding support to update update library with local kernel by passing local directory through KERNEL_VERSION, like:
This allows to test latest kernel uapi changes with ebpf/cilium library and tetragon.