l2announcer: Fix delete entry if no origins left #32279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
|
Commit 7865454 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
wutz
force-pushed
the
fix-l2announcher-delete-entry
branch
from
7865454
to
d956407
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
|
Commit 11ab162 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
When enabling L2Announcer and using the sharedingkeys feature, deleting a service that uses the same requestIP will unexpectedly delete the allocated LB IP in the Cilium agent. Fixes: cilium#32115 Signed-off-by: Taizeng Wu <wutaizeng@gmail.com>
wutz
force-pushed
the
fix-l2announcher-delete-entry
branch
from
11ab162
to
8a0362e
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
|
/test |
aanm
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
youngnick
approved these changes
May 6, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling L2Announcer and using the sharedingkeys feature, deleting a service that uses the same requestIP will unexpectedly delete the allocated LB IP in the Cilium agent.
Fixes: #32115