Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud-provider: Replace gocheck with built-in go test #32212

Merged
merged 3 commits into from Apr 30, 2024
Merged

cloud-provider: Replace gocheck with built-in go test #32212

merged 3 commits into from Apr 30, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Apr 28, 2024 •
edited

Please refer to individual commits for more details, this PR is focusing on files owned by cilium/{aws,aliababa,azure} teams.

Relates: #28596

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 28, 2024
@sayboras sayboras added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Apr 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 28, 2024
@sayboras sayboras marked this pull request as ready for review April 28, 2024 12:15
@sayboras sayboras requested review from a team as code owners April 28, 2024 12:15
@sayboras
Copy link
Member Author

/ci-integration

gandro
gandro approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor nits, otherwise this looks still good to me!

pkg/alibabacloud/eni/node_test.go Show resolved Hide resolved
pkg/aws/eni/eni_gc_test.go Show resolved Hide resolved
@sayboras
Copy link
Member Author

/test

JamesLaverack
JamesLaverack reviewed Apr 29, 2024
View reviewed changes
pkg/alibabacloud/eni/node_test.go Show resolved Hide resolved
pkg/alibabacloud/eni/node_test.go Outdated Show resolved Hide resolved
pkg/alibabacloud/eni/node_test.go Outdated Show resolved Hide resolved
pkg/aws/ec2/mock/mock_test.go Show resolved Hide resolved
pkg/aws/ec2/mock/mock_test.go Outdated Show resolved Hide resolved
pkg/aws/eni/limits/limits_test.go Outdated Show resolved Hide resolved
pkg/azure/api/mock/mock_test.go Show resolved Hide resolved
pkg/azure/api/mock/mock_test.go Outdated Show resolved Hide resolved
@sayboras
pkg/aws: Replace gocheck with built-in go test
a3e9f0f 
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
pkg/alibabacloud: Replace gocheck with built-in go test
94aa886 
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
pkg/azure: Replace gocheck with built-in go test
ea0d2a5 
One point worth noting is the removal of api_interaction_test.go. This
test is not even complied and didn't run for a long time, so better just
clean it up.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
Copy link
Member Author

/test

@sayboras sayboras added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit c573be4 Apr 30, 2024
262 of 265 checks passed
@sayboras sayboras deleted the pr/tammach/gocheck-cloud branch April 30, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@gandro gandro gandro approved these changes

@christarazi christarazi christarazi approved these changes

@JamesLaverack JamesLaverack Awaiting requested review from JamesLaverack

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sayboras @gandro @JamesLaverack @christarazi @tommyp1ckles