New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata to annotation-derived l7 policy #32166
Add metadata to annotation-derived l7 policy #32166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Overall seems straightforward, though I have some nits (bordering in bikeshedding) with regards to the artificial labels used
5c721ac
to
20cc159
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(L7 visibility annotation feature is deprecating, this is not a blocker to merge this PR, just to provide some more context) |
/test |
20cc159
to
1dde633
Compare
/test |
This change adds metadata labels to L7 DNS allow-all visibility policies derived from pod annotation in order to inform user about which pod annotations caused policy creation. Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
1dde633
to
b3923c8
Compare
/test |
This change adds metadata labels to L7 DNS allow-all visibility policies derived from pod annotation in order to inform user about which pod annotations caused policy creation.
Fixes: #31359