Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to annotation-derived l7 policy #32166

Merged

Conversation

nebril
Copy link
Member

@nebril nebril commented Apr 24, 2024

This change adds metadata labels to L7 DNS allow-all visibility policies derived from pod annotation in order to inform user about which pod annotations caused policy creation.

Fixes: #31359

Added source pod metadata to generated L7 DNS visibility policies. 

@nebril nebril added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Apr 24, 2024
@nebril nebril requested review from a team as code owners April 24, 2024 12:42
@nebril nebril requested review from gandro and aditighag April 24, 2024 12:42
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall seems straightforward, though I have some nits (bordering in bikeshedding) with regards to the artificial labels used

pkg/policy/visibility.go Outdated Show resolved Hide resolved
@nebril nebril requested a review from gandro April 24, 2024 13:38
@nebril nebril force-pushed the pr/nebril/add-metadata-labels-for-l7-allow-all branch from 5c721ac to 20cc159 Compare April 24, 2024 13:38
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sayboras
Copy link
Member

(L7 visibility annotation feature is deprecating, this is not a blocker to merge this PR, just to provide some more context)

@nebril
Copy link
Member Author

nebril commented Apr 24, 2024

/test

@nebril nebril force-pushed the pr/nebril/add-metadata-labels-for-l7-allow-all branch from 20cc159 to 1dde633 Compare April 25, 2024 10:27
@nebril nebril requested a review from aditighag April 25, 2024 10:27
@nebril
Copy link
Member Author

nebril commented Apr 25, 2024

/test

This change adds metadata labels to L7 DNS allow-all visibility policies
derived from pod annotation in order to inform user about which pod
annotations caused policy creation.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril force-pushed the pr/nebril/add-metadata-labels-for-l7-allow-all branch from 1dde633 to b3923c8 Compare April 25, 2024 12:46
@nebril
Copy link
Member Author

nebril commented Apr 26, 2024

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 29, 2024
@nebril nebril added this pull request to the merge queue Apr 29, 2024
Merged via the queue into cilium:main with commit b1c2396 Apr 29, 2024
64 checks passed
@nebril nebril deleted the pr/nebril/add-metadata-labels-for-l7-allow-all branch April 29, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metadata labels for cilium policy selectors to support visibility policy L7 allow-all
4 participants