envoy: add support to bind to privileged ports #32158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
kind/feature
mhofstetter
force-pushed
the
pr/mhofstetter/envoy-support-priv-ports
branch
2 times, most recently
from
5327e0e
to
88de362
Compare
This commit updates Envoy (Cilium Proxy) to the latest version from (`ciilum/proxy` - `main`) that includes support to keep the capability `NET_BIND_SERVICE`. Relates to: cilium/proxy#650 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Currently, the Envoy process of the Cilium Proxy doesn't have the capabilities to bind to privileged ports. Even if the respective capabilities would be configured in the Pods SecurityContext, the `cilium-envoy-starter` would drop all capabilities before starting the Envoy process. This commit adds support for binding to privileged ports by introducing a new Helm value `envoy.securityContext.capabilities.keepCapNetBindService` (`bool` - defaults to `false`). If set to `true`, the `cilium-envoy-starter` keeps the capability `NET_BIND_SERVICE` when starting the Envoy process. This way, it's possible to bind to privileged ports. Note: It's still required to add the capability `NET_BIND_SERVICE` to the respective container * daemonset mode: `envoy.securityContext.capabilities.envoy` * embedded mode: `securityContext.capabilities.ciliumAgent` Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/envoy-support-priv-ports
branch
from
88de362
to
1db5f40
Compare
|
/test |
mhofstetter
commented
Apr 25, 2024
3 tasks
nebril
approved these changes
Apr 26, 2024
jrajahalme
approved these changes
Apr 29, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Envoy process of the Cilium Proxy doesn't have the capabilities to bind to privileged ports. Even if the respective capabilities would be configured in the Pods SecurityContext, the
cilium-envoy-starterdrops all capabilities before starting the Envoy process.This commit adds support for binding to privileged ports by introducing a new Helm value
envoy.securityContext.capabilities.keepCapNetBindService(bool- defaults tofalse).If set to
true, thecilium-envoy-starterkeeps the capabilityNET_BIND_SERVICEwhen starting the Envoy process. This way, it's possible to bind to privileged ports.Note: It's still required to add the capability
NET_BIND_SERVICEto the respective container via Helm valuesenvoy.securityContext.capabilities.envoysecurityContext.capabilities.ciliumAgentRelated to: #30840