Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lb ip is deleted accidentally in statedb when l2announce, requestip and shardingkeys are used together #32115

Closed
2 of 3 tasks
wutz opened this issue Apr 22, 2024 · 2 comments · Fixed by #32279
Closed
2 of 3 tasks
Labels
feature/l2-announcement kind/bug This is a bug in the Cilium logic. kind/community-report This was reported by a user in the Cilium community, eg via Slack. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.

Comments

@wutz
Copy link
Contributor

wutz commented Apr 22, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

  1. enable l2announce
  2. create multiple services with same annotations io.cilium/lb-ipam-ips and io.cilium/lb-ipam-sharing-key
  3. delete some services
  4. execute cilium-dbg statedb l2-announce to see the ip is missing

Cilium Version

1.15.3

Kernel Version

5.15.0-102-generic

Kubernetes Version

v1.28.7+k3s1

Regression

Bug

Sysdump

https://drive.google.com/file/d/1C3Y-glpgfJ0efHDFfr5TqO5hI4KOkWar/view?usp=drive_link

Relevant log output

No response

Anything else?

When creating multiple services using the same IP, you can still see the IP listed multiple times in the statedb on multiple nodes.

Cilium Users Document

  • Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

  • I agree to follow this project's Code of Conduct
@wutz wutz added kind/bug This is a bug in the Cilium logic. kind/community-report This was reported by a user in the Cilium community, eg via Slack. needs/triage This issue requires triaging to establish severity and next steps. labels Apr 22, 2024
@ashertz-dev
Copy link

+1

@wutz
Copy link
Contributor Author

wutz commented Apr 23, 2024

If the Cilium agent is restarted on the lb IP node, this IP will appear again in the statedb.

@ti-mo ti-mo added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. feature/l2-announcement and removed needs/triage This issue requires triaging to establish severity and next steps. labels Apr 25, 2024
wutz added a commit to wutz/cilium that referenced this issue May 1, 2024
When enabling L2Announcer and using the sharedingkeys feature,
deleting a service that uses the same requestIP will unexpectedly
delete the allocated LB IP in the Cilium agent.

Fixes: cilium#32115

Signed-off-by: Taizeng Wu <wutaizeng@gmail.com>
wutz added a commit to wutz/cilium that referenced this issue May 1, 2024
When enabling L2Announcer and using the sharedingkeys feature,
deleting a service that uses the same requestIP will unexpectedly
delete the allocated LB IP in the Cilium agent.

Fixes: cilium#32115

Signed-off-by: Taizeng Wu <wutaizeng@gmail.com>
github-merge-queue bot pushed a commit that referenced this issue May 6, 2024
When enabling L2Announcer and using the sharedingkeys feature,
deleting a service that uses the same requestIP will unexpectedly
delete the allocated LB IP in the Cilium agent.

Fixes: #32115

Signed-off-by: Taizeng Wu <wutaizeng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/l2-announcement kind/bug This is a bug in the Cilium logic. kind/community-report This was reported by a user in the Cilium community, eg via Slack. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants