-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IPv6 in connectivity tests #2545
base: main
Are you sure you want to change the base?
Conversation
Commit 0bda11d does not match "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
This commit brings support for IPv6 addresses specified in options --external-ip and --external-other-ip for the cilium connectivity test command. Signed-off-by: Léo El Amri <leo@superlel.me>
0bda11d
to
aa7b502
Compare
return net.ParseIP(s) != nil && strings.Contains(s, ":") | ||
} | ||
|
||
func EnsureIPv6InBackets(s string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
func EnsureIPv6InBackets(s string) string { | |
func EnsureIPv6InBrackets(s string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit comment, otherwise LGTM 🚀
As of today, values specified in options
--external-ip
and--external-other-ip
are assumed to be IPv4 addresses in several places in the code. This cause some tests to fail even when a proper IPv6 configuration is specified with options--external-cidr
,--external-ip
,--external-other-ip
and--external-target
. This pull request remove the assumptions that these options holds IPv4 addresses.