Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attune Item Support #5084

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Teksura
Copy link
Contributor

@Teksura Teksura commented Nov 20, 2023

Adding support for Attune Item in a way that makes me furious but technically works.

If anyone does somehow end up in a situation where they need this at IG 13 or above, congratulations... Okay, fine. Just take the 12+ accessory and then as many +1 accessories as you need. Don't @ me though because this is more your fault than mine WTF are you even doing at IG 13?

Resolves #5078 I guess. But I'm still not happy with the way this works.

Adding Attune Item Improvement to resolve chummer5a#5078
Adding support for Attune Item in a way that makes me furious but technically works. 

If anyone does somehow end up in a situation where they need this at IG 13 or above, congratulations... Okay, fine. Just take the 12+ accessory and then as many +1 accessories as you need. Don't @ me though because this is more your fault than mine WTF are you even doing at IG 13?
@DelnarErsike
Copy link
Collaborator

I'm not super-happy with this solution because it's extremely hacky. I'd honestly much prefer if this was something implemented in the C# side, e.g. by incorporating initiate and/or submersion grade as a dedicated keyword that could be fetched for calculations the same way attributes can.

@EmmjayXII
Copy link

I'm not super-happy with this solution because it's extremely hacky. I'd honestly much prefer if this was something implemented in the C# side, e.g. by incorporating initiate and/or submersion grade as a dedicated keyword that could be fetched for calculations the same way attributes can.

A neat side benefit of that sort of code implementation would also be that it'd allow for several metamagics to be fully implemented in the program (e.g. Essence Expansion, Presence, Shielding, and so on) without having to keep track of them manually.

@Teksura
Copy link
Contributor Author

Teksura commented Nov 27, 2023

I'm not super-happy with this solution because it's extremely hacky. I'd honestly much prefer if this was something implemented in the C# side, e.g. by incorporating initiate and/or submersion grade as a dedicated keyword that could be fetched for calculations the same way attributes can.

I agree. My skills however are limited to XML fuckery. And good god this is some fuckery. So I did the best my abilities could muster.

Your described solution would be far superior and would be able to apply in other situations as well. Perhaps something like being able to use {IG} or {SG}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] An "Attuned Weapon" Weapon Modification to keep track of attuned weapons.
3 participants