Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] An "Attuned Weapon" Weapon Modification to keep track of attuned weapons. #5078

Open
EmmjayXII opened this issue Nov 11, 2023 · 8 comments · May be fixed by #5084
Open

[Feature Request] An "Attuned Weapon" Weapon Modification to keep track of attuned weapons. #5078

EmmjayXII opened this issue Nov 11, 2023 · 8 comments · May be fixed by #5084

Comments

@EmmjayXII
Copy link

Although it is possible to manually keep track of attuned equipment for Adepts/Mystic Adepts, it would be preferable in my opinion to have an "Attuned Item" weapon modification available for all weapons to do so automatically. I am not sure if it would be possible for these attachments to reference the character's initiate grade, but if not, it would be possible to implement as a weapon modification that takes up no slots, is available for all weapons, and has an arbitrarily high maximum rating, adding +1 Accuracy per rating.

If it is possible to reference the character's initiate grade, then it could simply reference that and add that number to Accuracy.

@EmmjayXII EmmjayXII changed the title Requesting an "Attuned Weapon" Weapon Modification to keep track of attuned weapons. [Feature Request] An "Attuned Weapon" Weapon Modification to keep track of attuned weapons. Nov 11, 2023
@Teksura
Copy link
Contributor

Teksura commented Nov 20, 2023

If it is possible to reference the character's initiate grade, then it could simply reference that and add that number to Accuracy.

My concern with that is while it's doable, you'll have to remove and re-add it when you gain an initiate grade.

@Teksura
Copy link
Contributor

Teksura commented Nov 20, 2023

Got almost working.

    <accessory>
      <id>0fcf55fa-afb4-487c-93f2-f41d6fc4e769</id>
      <name>Attuned Item</name>
      <mount />
      <avail>0</avail>
      <cost>0</cost>
      <source>SG</source>
      <page>124</page>
      <rating>0</rating>
      <accuracy>1</accuracy>
      <required>
        <oneof>
          <spell>Attune Item</spell>
        </oneof>
      </required>
    </accessory>

This technically resolves this, but you're required to add the weapon modification a number of times equal to your IG. Obviously that's not ideal. I'm looking into seeing what I have to do to make the bonus pull your IG like how {MAG} would pull your magic. If that doesn't work, uhh, can weapon mods even take ratings? I've never tried, and the fact that Gas-Vent system is designed the way it is is... Not encouraging.

Teksura added a commit to Teksura/chummer5a that referenced this issue Nov 20, 2023
Adding Attune Item Improvement to resolve chummer5a#5078
@Teksura
Copy link
Contributor

Teksura commented Nov 20, 2023

So this works fine.... ish.

    <!-- Region Attune Item -->
    <accessory>
      <id>0fcf55fa-afb4-487c-93f2-f41d6fc4e769</id>
      <name>Attuned Item: (IG 1)</name>
      <mount />
      <avail>0</avail>
      <cost>0</cost>
      <source>SG</source>
      <page>124</page>
      <accuracy>1</accuracy>
      <required>
        <allof>
          <spell>Attune Item</spell>
          <initiategrade>1</initiategrade>
        </allof>
      </required>
      <forbidden>
        <oneof>
          <initiategrade>2</initiategrade>
        </oneof>
      </forbidden>
    </accessory>
    <accessory>
      <id>53286bfd-2d55-4bfa-b7d4-6c55d1d2c7bf</id>
      <name>Attuned Item: (IG 2)</name>
      <mount />
      <avail>0</avail>
      <cost>0</cost>
      <source>SG</source>
      <page>124</page>
      <accuracy>2</accuracy>
      <required>
        <allof>
          <spell>Attune Item</spell>
          <initiategrade>2</initiategrade>
        </allof>
      </required>
      <forbidden>
        <oneof>
          <initiategrade>3</initiategrade>
        </oneof>
      </forbidden>
    </accessory>

It's an obnoxious way to go about it and would require a modification for each IG, but it works. It's just really jank. I'm going to hold off on pushing this until I hear back on if there is a better way to do the bonus.

@Teksura Teksura linked a pull request Nov 20, 2023 that will close this issue
@Stexinator
Copy link
Contributor

I created it for level 1,2 and 3 => you can mix and have every number in grasp without a dozen of attachments

@Teksura
Copy link
Contributor

Teksura commented Nov 23, 2023

I created it for level 1,2 and 3 => you can mix and have every number in grasp without a dozen of attachments

At that point if you're IG 7 you need to add 3 different attachments as opposed to having just 1.

@Stexinator
Copy link
Contributor

I created it for level 1,2 and 3 => you can mix and have every number in grasp without a dozen of attachments

At that point if you're IG 7 you need to add 3 different attachments as opposed to having just 1.

Yes, but how many of your players have IG 7? I agree that this is just a band aid due to not being able to dynamically calculate it. But I made the experience that these 3 are mostly enough

@Teksura
Copy link
Contributor

Teksura commented Nov 24, 2023

If you don't like the #5084 proposed fix, I invite you to open another pull request to address the issue in a better way.

This was the best solution I could come up with since I couldn't have the weapon modifier pull the characters IG, and didn't want to have multiple attachments on the same weapon to apply a bonus. This problem was identified in my above comment, as it required adding 1 additional copy of the modification per IG, which looked pretty dumb and took up a lot of unnecessary space.

I would have liked to have set it up so you pick ranks and it gives a bonus based on ranks so you just set the rank to equal your IG, but, that didn't work either.

Both what you describe and what I did are basically the same solution, with the only difference being mine goes up higher before you need to add multiple modifications, and mine hides unnecessary modifications in the menu.

@Stexinator
Copy link
Contributor

Ah, didnt saw that you already provided a fix. I thought we are discussing possible solutions for this issue. I am totally fine with you adding any number :) I just didnt want to do it myself in my custom files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants