Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional row for error message. #115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

panmari
Copy link

@panmari panmari commented Apr 9, 2024

Useful for researching if there are different types of errors for different types of permission issues.

Useful for researching if there are different types of errors for different types of permission issues.
one-time.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@lgarron lgarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits.

one-time.html Outdated Show resolved Hide resolved
* Make it more clear only error messages are surfaced
* Add blank indicators
Copy link
Collaborator

@lgarron lgarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants