Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in bitmap_pipeline.md #212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typo in bitmap_pipeline.md #212

wants to merge 1 commit into from

Conversation

shuoer86
Copy link

No description provided.

@google-cla Google CLA
Copy link

google-cla bot commented Jan 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@shuoer86 shuoer86 closed this Jan 18, 2024
@shuoer86 shuoer86 reopened this Jan 18, 2024
aarongable pushed a commit that referenced this pull request Jan 19, 2024
Roll Chrome Mac PGO Profile
8573005 
Roll Chrome Mac PGO profile from chrome-mac-6099-1699220220-d5abfdc2ddd5b81e0c9c01299271b989f8d96eb4.profdata to chrome-mac-6099-1699241318-1c5e95b5b39af6607df122bfc9b1dfef8f9440a7.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m120.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia86227dd3ffc587fcebfd42ee8056827406c13e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5007494
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{#212}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 19, 2024
[DBSC] Limit DiceCookieBoundSessionService to gaia included session
5c0dfd1 
Limit the operations needed on bound session termination to sessions
that includes Gaia url. On a follow-up CL, bound cookies will be
deleted.

(cherry picked from commit 85a3a41)

Bug: b/314281485
Change-Id: I93495e4aa20b57380320ba4a6a365fcbed872b1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5078594
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1233946}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5110281
Auto-Submit: Monica Basta <msalama@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6167@{#212}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable pushed a commit that referenced this pull request Jan 19, 2024
[M118][UPMLocalPwd] Showing a blank sheet resets the timestamp
201307f 
An empty sheet can be shown if it's interrupted during showing.
It looks like a gray line with only a big scrim behind it.
In rare cases when a user sees this, the timestamp should not be
recorded and the sheet should be reshown as soon as the next triggering
action occurs.

We also want to check the hypothesis that the sheet can be
interrupted only on startup. That's why a new histogram is added.

(cherry picked from commit 3dd6963)

Bug: 1479012
Change-Id: I8b65a4a62df7bfb6aa1c77d58adeb8362fa9cab5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4846677
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Ivana Žužić <izuzic@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1194170}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4858243
Cr-Commit-Position: refs/branch-heads/5993@{#212}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
aarongable pushed a commit that referenced this pull request Jan 26, 2024
Roll v8 11.4 from ec7ad04fc590 to 0dae2c459f61 (2 revisions)
5b38368 
https://chromium.googlesource.com/v8/v8.git/+log/ec7ad04fc590..0dae2c459f61

2023-05-03 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 11.4.183.6
2023-05-03 victorgomes@chromium.org Merged: [maglev] Add eager deopt register to register snapshot

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-11-4-chromium-m114
Please CC liviurau@google.com,v8-waterfall-sheriff@grotations.appspotmail.com,vahl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in v8 11.4: https://bugs.chromium.org/p/v8/issues/entry
To file a bug in Chromium m114: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: v8-waterfall-sheriff@grotations.appspotmail.com
Change-Id: Ia63a2fe38df86a0091612e1ffed7dae6865cf643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4503474
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5735@{#212}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
aarongable pushed a commit that referenced this pull request Jan 29, 2024
Roll Chrome Win64 PGO Profile
722d3d5 
Roll Chrome Win64 PGO profile from chrome-win64-6261-1706478259-a2f733f3e583d03e0b932c6f3966becdaeb15c30.profdata to chrome-win64-6261-1706498537-1dbc2fbd9f695ceb046210d20a265acda9687218.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m122.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Id55ce5a9d89ee931f73b3aee2876723a2a6c4497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5244283
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6261@{#212}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
NaaeemMalik pushed a commit to AsilHQ/Asil-Chromium that referenced this pull request Feb 8, 2024
Roll ChromeOS Bigcore AFDO profile from 118-5978.0-1695634679-benchma…
25ef923 
…rk-119.0.6036.0-r1 to 119-6036.0-1696845620-benchmark-119.0.6045.15-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Id3ba76378dc6e732c66b1d54ba80b3597a5afad4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4922547
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#212}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
ecotopian pushed a commit to ecosia/chromium-android-browser that referenced this pull request Feb 12, 2024
[M111 Merge] Add metrics logging for every card unmask preflight flow…
657c012 
… initiated

This CL adds merics every time we initiate a card unmask preflight flow.
These metrics will be important in conjunction with
Autofill.BetterAuth.CardUnmaskPreflightCalledWithFidoOptInStatus to
understand the proportion of devices that have FIDO capabilities.

(cherry picked from commit 2dbc36f)

Bug: 1412782
Change-Id: Ieb833a3575f8601db7e3ce3a6006fbd610bf4e03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200998
Reviewed-by: Siyu An <siyua@chromium.org>
Reviewed-by: Vidhan Jain <vidhanj@google.com>
Commit-Queue: Vinny Persky <vinnypersky@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1101012}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4221017
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5563@{chromium#212}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable pushed a commit that referenced this pull request Feb 27, 2024
[M123] FLEDGE: Do not store pointers to AdAuctionPageData and its Dat…
5df547a 
…aDecoder

... in AuctionRunner/InterestGroupAuction. Those things are owned by
the Page and they can, it turns out, become invalid under certain
circumstances (involving some kinds of page unload) during the
auction's  lifetime. So instead store factory functions and null-
check the result, using the page-has-changed magic in their 
implementation.

Thanks to Xiaochen Zhou for help diagnosing this; the testcase is 
also largely based on his earlier work in the area.

(cherry picked from commit 852b335)

Bug: 326085515
Change-Id: I3702c583246c4162447fe631b4a55527de1a8e6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314060
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Russ Hamilton <behamilton@google.com>
Reviewed-by: Xiaochen Zhou <xiaochenzh@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1263599}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5319613
Cr-Commit-Position: refs/branch-heads/6312@{#212}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
gcjenkinson pushed a commit to chromium-cheri/chromium that referenced this pull request Mar 15, 2024
Roll Chrome Linux PGO Profile
334388d 
Roll Chrome Linux PGO profile from chrome-linux-5790-1685572025-6a2f8e3fe0e79c614cc2593a21521cd8f1da023c.profdata to chrome-linux-5790-1685595566-ba09a8b983fd723daa7f68fa0057e589cc1e9716.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m115.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Icb86b2b1dcb310cfd2a658aa5be40fb63c89005d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576579
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5790@{chromium#212}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
NaaeemMalik pushed a commit to SoftwarePrince/Egon-Chromium that referenced this pull request Mar 22, 2024
Incrementing VERSION to 117.0.5938.14
c1fcd17 
Change-Id: If8e5183c4c330f9a952c476a13b4838e420b8d87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4787767
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5938@{chromium#212}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable pushed a commit that referenced this pull request Mar 25, 2024
[M124][LogoPolish] Implement logo polish.
6f2cf71 
This CL modifies the height, top margin, and bottom margin of the logo
when Logo Polish is activated. The height of the logo is decided by the
selected variation.

The screenshots are included in the following link:
https://docs.google.com/document/d/16z7y1lXiSJ0sCZ0-UzrXdBC8H2idDrVdVarJ4DIEuho/edit?usp=sharing

(cherry picked from commit 89460ed)

Bug: 328769923
Change-Id: I4d77d36271ea7e5a8b0f620fafae09d614d238de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5356197
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Xinyi Ji <xinyiji@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1275663}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5391681
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6367@{#212}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 22, 2024
@yezengfeng
[M125]Revert "[iOS] Avoid forcing layout location bar for unanimated …
5997ce9 
…expand/contract"

This reverts commit d12bc76.

Reason for revert: Caused a UIViewKeyframeAnimations crash
(https://g-issues.chromium.org/issues/333331927), and it can't be fixed
soon, revert it first.

Original change's description:
> [iOS] Avoid forcing layout location bar for unanimated expand/contract
>
> Expand/contract location bar will force layout immediately with a call
> to `layoutIfNeeded`, but the layout is not necessary at startup. The
> layout adds ~25ms to the startup latency on the iPhone 7 (according to
> Instruments).
> This CL avoids forcing layout location bar for unanimated
> expand/contract to reduce unnecessary costs at startup.
>
> Instruments measurements:
> https://docs.google.com/document/d/1gyVFWPn2WDPIyi5zY1WFUjhsL2Z26RsUyHLNw87lIWE/edit?usp=sharing
>
> Bug: 1515588
> Change-Id: I57528e590a45e0e77c890cd264cb1b1f9e749f85
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5252574
> Reviewed-by: Joemer Ramos <joemerramos@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: Zengfeng Ye <zenye@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#1254871}

(cherry picked from commit 602d749)

Bug: 1515588
Change-Id: I560d5bf9d878c7728dadfcbdad00f86276669776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465605
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Zengfeng Ye <zenye@microsoft.com>
Reviewed-by: Joemer Ramos <joemerramos@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1290309}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465193
Commit-Queue: Joemer Ramos <joemerramos@chromium.org>
Cr-Commit-Position: refs/branch-heads/6422@{#212}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@shuoer86