Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test 001b #209

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

test 001b #209

wants to merge 6 commits into from

Conversation

dcidddbeatlecom
Copy link

No description provided.

@google-cla Google CLA
Copy link

google-cla bot commented Dec 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

trflynn89 pushed a commit to RebelBrowser/rebel that referenced this pull request Dec 14, 2023
Roll Chrome Win64 PGO Profile
aeb0f4b 
Roll Chrome Win64 PGO profile from chrome-win64-6099-1699205229-0c9e9dbeb1e3a34f381ae853a271c28f691cc516.profdata to chrome-win64-6099-1699220220-643d8500d6e5a29dd6f315d84beefe315e4a82c5.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m120.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I15e78707d33cf175753037de087d695c5919dfdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006700
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{chromium#209}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 6, 2024
Automated Commit: LKGM 15699.9.0 for chromeos.
ee018b2 
Uploaded by https://ci.chromium.org/b/8762045600759520977

Change-Id: I46171aebfb85551f91ad09675aec538da56a6597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5109687
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6167@{#209}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable pushed a commit that referenced this pull request Jan 10, 2024
[M118][sync] Fix logic to count bookmarks, extract domain in sync_cli…
e58f430 
…ent_utils

This CL fixes the following:
1. Updates that managed bookmarks are not counted, while duplicate
bookmarks are counted, by LocalDataQueryHelper.
2. Updates logic to extract domain from url. The existing logic didn't
work well for addresses like "chrome://flags".

(cherry picked from commit 52977e2)

Bug: 1451508
Change-Id: Ib00c637a1a43eb9167a683d91056ca0a962631db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4856642
Commit-Queue: Ankush Singh <ankushkush@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1195021}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4856805
Cr-Commit-Position: refs/branch-heads/5993@{#209}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
aarongable pushed a commit that referenced this pull request Jan 15, 2024
Roll Chrome Linux PGO Profile
a901361 
Roll Chrome Linux PGO profile from chrome-linux-5735-1683090713-02d062537c35098bc2d165f9ef98e66e3d991ec9.profdata to chrome-linux-5735-1683115063-7cee98c08e4beac0bb9df377dea4ecbb9632ed5b.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m114.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I76ec0534270be1f279eaf257abd202969ad23b69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4503469
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5735@{#209}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
aarongable pushed a commit that referenced this pull request Jan 29, 2024
Roll Chrome Mac PGO Profile
9763aa6 
Roll Chrome Mac PGO profile from chrome-mac-6261-1706478259-1055b7f85864f8807618a56ac9b52e5e0dcb9919.profdata to chrome-mac-6261-1706498537-49dd14b6e1773217df8cdeb5fa0c5a5762661632.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m122.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Idb7a8b7704828948f768c27015b8e84fd9e81ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5244235
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6261@{#209}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
NaaeemMalik pushed a commit to AsilHQ/Asil-Chromium that referenced this pull request Feb 8, 2024
Roll src/third_party/pdfium from 8cf636e15ce2 to 2e2cfb0399db
8abc39e 
Commits rolled:
https://pdfium.googlesource.com/pdfium.git/+log/8cf636e15ce2..2e2cfb0399db

Generated by: go/bbid/8767688166552336833

Change-Id: I2d1f33a212d3c7b3fb0ddc8a12cbc91ac422f308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4923709
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#209}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
ecotopian pushed a commit to ecosia/chromium-android-browser that referenced this pull request Feb 12, 2024
[M111][SafetyCheck] Add undo for 'Allow again' action for unused site…
3b832af 
…s module

When clicking 'Allow again' for an origin's revoked permissions in the unused sites module the permission(s) is(are) granted again, the item is removed from the list of revoked permissions, and the origin is added to an ignore list for the future. This CL adds the undo functionality on the CPP side (TS side already landed).

(cherry picked from commit 80d1dd0)

Bug: 1345920, 1409416
Change-Id: If88b1a7d5a988dabfa0260c1725b4d1998523fed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4176863
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Illia Klimov <elklm@chromium.org>
Commit-Queue: Eduard Hez <ehez@chromium.org>
Reviewed-by: Rainhard Findling <rainhard@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1098533}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4224614
Commit-Queue: Illia Klimov <elklm@chromium.org>
Auto-Submit: Eduard Hez <ehez@chromium.org>
Cr-Commit-Position: refs/branch-heads/5563@{chromium#209}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable pushed a commit that referenced this pull request Feb 27, 2024
[M123] Revert "Fix CHIPS for WebView when 3PCs are not enabled"
1b9a7a1 
This reverts commit cda963b.

Reason for revert: Looks like this is introducing a performance regression (see crbug.com/324328158). It is likely caused by the std::copy_if. It could also be happening if the performance tests are not enabling 3PCs in the first place because then we'd be causing more work to happen than what was happening previously.

Original change's description:
> Fix CHIPS for WebView when 3PCs are not enabled
>
> If an Android developer disables 3PCs in their app, paritioned cookies
> will not be returned. The root cause of this is that WebView uses its
> own settings for cookies from the rest of Chromium.
>
> The behaviour of Chromium is that partitioned cookies are still returned
> when 3PCs are disabled so we are matching that.
>
> Because permissions apply at the level of BrowserContext for the rest of
> Chromium, we have to do an awkward work around here where we
> optimistically retrieve all cookies, and then filter out the non
> partitioned cookies. This is because we have no way of telling the lower
> layers that this is the behaviour we want for _this_ WebView. There may
> be a slight performance impact here but hopefully not a large one since
> apps that have 3PCs disabled wouldn't be setting them in the first
> place. The real issue is more around apps changing this setting at
> runtime.
>
> Bug: 1523962
> Change-Id: Ic46a58651d16b85ff9287c52c4f4a89c39274107
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5250507
> Commit-Queue: Rupert Wiser <bewise@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1257451}

(cherry picked from commit debc104)

Bug: 1523962
Change-Id: I81e01faafd5c176a152088bebfdcc2bf5c3f363d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314720
Reviewed-by: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Commit-Queue: Rupert Wiser <bewise@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1263981}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5326801
Owners-Override: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/6312@{#209}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
gcjenkinson pushed a commit to chromium-cheri/chromium that referenced this pull request Mar 15, 2024
Roll Chrome Win64 PGO Profile
c3d6b61 
Roll Chrome Win64 PGO profile from chrome-win64-5790-1685553847-ca32191a15281b85d6b677c801d86b1efce3890d.profdata to chrome-win64-5790-1685572025-94a97b7dd58f8c4c88340160ddfeb135c0eac6ff.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m115.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Id250bad4b02673af653977e61aa7b4ef19b58f8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4578183
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5790@{chromium#209}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
NaaeemMalik pushed a commit to SoftwarePrince/Egon-Chromium that referenced this pull request Mar 22, 2024
[M117][Failed test fix] Automate native PersistedTabData removal upon…
42785e5 
… Tab close

This CL adds functionality to remove all PersistedTabData stored
for a Tab when the Tab is closed.

The original CL had a test failure on one builder crbug.com/1471874.
The reason is is_sensitive was being saved without being assigned
a value. This CL assigns it a default value of false.

The original CL is patch 1. The updated CL with the fix is patch 2.

Merge bug: 1472834
(cherry picked from commit d07f4fb)

Bug: b/290827631
Change-Id: I26ea71c3725a6109c0416325dfdb31fe2004cf33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4772215
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1182661}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4779640
Owners-Override: Harry Souders <harrysouders@google.com>
Cr-Commit-Position: refs/branch-heads/5938@{chromium#209}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable pushed a commit that referenced this pull request Mar 25, 2024
Roll Chrome Win32 PGO Profile
4433307 
Roll Chrome Win32 PGO profile from chrome-win32-6367-1711339532-72d4729d77e1920a69e0808a351ae1ef44d11319-86072a8a4ae2686ab42b026a94b7aeeb8ed1b235.profdata to chrome-win32-6367-1711366904-d96ae799efb7b02632e00a72f44d229d3133fddc-c055d4ed29a25eb8dd7d7cb23be90527690440b5.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m124.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I4088f2c54326c719381cff826130a75b4b0cef11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5391355
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6367@{#209}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 22, 2024
Roll Chrome Win64 PGO Profile
b8e2288 
Roll Chrome Win64 PGO profile from chrome-win64-6422-1713763964-27930648ca471fdb84ad65bd7a4c4fb61a74c78d-122fe18cfe278bbe2b13f48c280bc843749ab114.profdata to chrome-win64-6422-1713785808-779a3cf6e0778041e9c04cc6abf79f183f32829e-5e9bb5deef0aa4e17f5acee0a37e4a39d47575a0.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m125.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I8861dfbeb04a775fa6595fbf6722f1b35e1d3a5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472446
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6422@{#209}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dcidddbeatlecom