New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing pt-PT language #205
Open
horus68
wants to merge
4
commits into
chromium:main
Choose a base branch
from
horus68:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aikoyori
pushed a commit
to Pissandshittium/pissandshittium
that referenced
this pull request
Dec 8, 2023
Change-Id: I27dffc853fecfd199688e3d1241986b53c080a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5007013 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{chromium#205} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
Roll Chrome Win32 PGO profile from chrome-win32-6167-1702246941-c07376b8091842aecc1e5f1ee0e5e21b74000776.profdata to chrome-win32-6167-1702265164-67db000701a674a8975f11770030728ab5da9ed7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I34e54de2cada33887db9dd428578760c23652b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5108391 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#205} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 10, 2024
Change-Id: I4ad1dcc90a7df8c012f6cb0dae9e3ec13f8af3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4858939 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5993@{#205} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
aarongable
pushed a commit
that referenced
this pull request
Jan 29, 2024
Roll Chrome Mac PGO profile from chrome-mac-6261-1706462268-3b977883f0f5c6ce31285a5b11c8da5cc340a268.profdata to chrome-mac-6261-1706478259-1055b7f85864f8807618a56ac9b52e5e0dcb9919.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m122.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id60351aa9b9fc32074a2ddaaa72f2494f4a8e814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5243766 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#205} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
NaaeemMalik
pushed a commit
to AsilHQ/Asil-Chromium
that referenced
this pull request
Feb 8, 2024
Change-Id: I79ff8f80bfd844972ae3d31bac5f5d44f5ba248f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4922190 Auto-Submit: Ben Mason <benmason@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#205} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
ecotopian
pushed a commit
to ecosia/chromium-android-browser
that referenced
this pull request
Feb 12, 2024
- Add padding between tab strip end and model selector button = touch_target_size - button_bg_size) / 2. - Add padding between model selector button and new tab button = 8dp. Final result(Folio example, detached right end padding would be 5dp because detached NTB bg size is 2dp larger than that of folio): Width without MSB: tab | 16dp | NTB | 6dp Width with MSB: tab | 16dp | NTB | 8dp | MSB | 6dp incognito off: https://screenshot.googleplex.com/5oPeMwnzbohLcW2 incognito on: https://screenshot.googleplex.com/4ViPBVoW2uBnvdZ RTL incognito on: https://screenshot.googleplex.com/BvFKZWFbtRCo3Qi RTL incognito off: https://screenshot.googleplex.com/8ZCpRFqyArpET8k Recording for tab scroll and reorder mode: https://drive.google.com/file/d/1U6gled8A4D5XxE6rpnbP7bukOKcUMhDw/view?usp=sharing&resourcekey=0--h9MnZOEs-DacD-KEt9K5A (cherry picked from commit d8871a4) Bug: 1408257 Change-Id: I93927773f85232c596f43dd1d87f5f0be6669e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4189702 Commit-Queue: Zhe Li <zheliooo@google.com> Reviewed-by: Sirisha Kavuluru <skavuluru@google.com> Reviewed-by: Neil Coronado <nemco@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1100798} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4225553 Cr-Commit-Position: refs/branch-heads/5563@{chromium#205} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable
pushed a commit
that referenced
this pull request
Feb 27, 2024
Adds another metric variant for the post-default browser abandonment metrics that covers a longer time window: 42 days - 21 days. To avoid having too many trivial helpers in default browser utils, this CL also gets rid of the variant-specific helpers in favor of letting callers use the parameterized helper. Finally, this CL tweaks the unit test covering the default abandonment helper to be more focused on the boundary conditions, and to add more checks for the new metric variant. (cherry picked from commit 6a8b813) Bug: 324445537 Change-Id: I625caef54947210329637917ad205c99d9416d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5303638 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by: Ginny Huang <ginnyhuang@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Gayane Petrosyan <gayane@google.com> Auto-Submit: Guillaume Jenkins <gujen@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1263619} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5327367 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/branch-heads/6312@{#205} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
gcjenkinson
pushed a commit
to chromium-cheri/chromium
that referenced
this pull request
Mar 15, 2024
This CL updates the ash version ['116.0.5804.0', '115.0.5790.7'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: Ia314f78032f118d685f73fde405c7f880214663f Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575827 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790@{chromium#205} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
NaaeemMalik
pushed a commit
to SoftwarePrince/Egon-Chromium
that referenced
this pull request
Mar 22, 2024
Roll Chrome Mac PGO profile from chrome-mac-5938-1692160680-384520de85d8d55806b28fce3c7bba53b57c8a8f.profdata to chrome-mac-5938-1692207472-6150c121de4e2d427db44f28d7a8580d685ffddd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m117.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib96f8e57fc2b1047f0c0ab345da7bd8eec92a9a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4785287 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938@{chromium#205} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable
pushed a commit
that referenced
this pull request
Mar 25, 2024
…eeded (cherry picked from commit bcdd7db) Bug: b/40284908 Change-Id: Ia839e3daf5bfc2f805417cafcee716a8c7652e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5377867 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Samar Chehade-Lepleux <samarchehade@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1276802} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5389309 Auto-Submit: Samar Chehade-Lepleux <samarchehade@google.com> Cr-Commit-Position: refs/branch-heads/6367@{#205} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
Apr 22, 2024
…rk-125.0.6422.9-r1 to 125-6398.0-1713174332-benchmark-125.0.6422.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: mobiletc-prebuild@google.com Change-Id: I0cab63846eb3612292f09fd4447668a58d2e793a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472281 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#205} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General fix for pt-PT language making for consistency and proper use of words like website, app, password.