First Pull Req #203

Tanvi-Chaudhari · 2023-11-14T15:59:15Z

No description provided.

google-cla · 2023-11-14T15:59:19Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Roll Chrome Linux PGO profile from chrome-linux-6099-1699180505-7f7d734b9c97c956420736700f3328fd9c1a1312.profdata to chrome-linux-6099-1699205229-739ba78a36c3cde5587a064c49272fe174962267.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m120.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5e6bbdfe608b82b2750fca0fdb24f1b5136d98bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006829 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{chromium#203} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}

Roll Chrome Mac PGO profile from chrome-mac-6167-1702246941-2705255477c71e8f9018d89891aae23dfabea4b2.profdata to chrome-mac-6167-1702265164-e24829a725fb80504316b25c9a23f161ba2bc3f2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id1d506579436b6962bbf2d42523bb76637beb530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5109141 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#203} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}

This will allow us to start trying out the deprecation with a list of sites, rather than the whole world. (cherry picked from commit 1687291) Change-Id: I264e480bf0921b5d9ba1cc84878fdc4e97a0fcc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4835668 Reviewed-by: Kentaro Hara <haraken@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1192824} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4855864 Owners-Override: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/branch-heads/5993@{#203} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}

Change-Id: I805180e448dce48f6eb18116166c4ae78f6cc6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5243122 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#203} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}

Automatic update for 2023-10-09 UTC Change-Id: Ibcf4d8bf7f26cef5665dd8461590e07340076675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4920954 Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#203} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}

Also add PSD to the survey configs so the surveys can be launched while passing that data. We want to trigger the HaTS survey for users that have been on battery AND unplugged in the last week. When moving around the code I lost the signal and was just checking whether the device has a battery and not whether they were unplugged. (cherry picked from commit b8d1343) Change-Id: I304f727e457df00f8776c73c516858b704ad5cfd Bug: 1400430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4214913 Commit-Queue: Alison Gale <agale@chromium.org> Reviewed-by: Francois Pierre Doray <fdoray@chromium.org> Reviewed-by: Dana Fried <dfried@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1100519} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4225811 Commit-Queue: Francois Pierre Doray <fdoray@chromium.org> Auto-Submit: Alison Gale <agale@chromium.org> Cr-Commit-Position: refs/branch-heads/5563@{chromium#203} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}

…untappable Makes the primary button of the default browser promo in Settings interactable once again. (cherry picked from commit ee6e654) Bug: 325515949 Change-Id: I0f6ea22b9588a9d16f4191ed9ef6f2a954ba6a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310534 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1263573} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5323353 Auto-Submit: Guillaume Jenkins <gujen@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/6312@{#203} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}

https://crrev.com/c/4414614 among other things converted a DCHECK into a CHECK, but in reality it looks like users run into failures, and hence crashes. To start with, this patch downgrades the condition back to a DCHECK failure. (cherry picked from commit e84d883) Change-Id: I57c940da7c9d5255ac24c548d777421a2bf0b56c Bug: 1410747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4577060 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1151244} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4577878 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Krishna Govind <govind@chromium.org> Owners-Override: Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/branch-heads/5790@{chromium#203} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}

Change-Id: Idd6fa2c94bbb979faad47a19202679b9fbbf377d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4786307 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938@{chromium#203} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

VoiceOver scroll ability comes from a special handling of the layout when VoiceOver is activated. Invalidate the layout when voice over is turned on/off to make sure the layout is correct. (cherry picked from commit c16a454) Fixed: 330856099 Change-Id: I1024de47dfa5030124eef29f335d3865946e8979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5385657 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by: Ewann Pellé <ewannpv@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1276830} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5385330 Cr-Commit-Position: refs/branch-heads/6367@{#203} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}

Roll Chrome Win64 PGO profile from chrome-win64-6422-1713733953-dbafb477922562c8337d74c2d25aae63d0c81e1c-e0be679e16b5bf10a1f284e3ddc1a9b4a84a8ab0.profdata to chrome-win64-6422-1713763964-27930648ca471fdb84ad65bd7a4c4fb61a74c78d-122fe18cfe278bbe2b13f48c280bc843749ab114.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m125.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4e23b0525cf6e8437e8c0cd5703e907267ae231b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469837 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#203} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}

Tanvi-Chaudhari added 4 commits November 14, 2023 21:26

Delete chrome/app/theme/default_100_percent/chromium/product_logo_16.png

1f08d76

Delete chrome/app/theme/default_100_percent/chromium/product_logo_32.png

46094ec

Add files via upload

6a988be

Merge branch 'chromium:main' into main

f814aad

Tanvi-Chaudhari added 11 commits November 14, 2023 21:31

Delete chrome/app/theme/default_200_percent/chromium/product_logo_16.png

a65daf1

Delete chrome/app/theme/default_200_percent/chromium/product_logo_32.png

3ed2d3c

Add files via upload

8074a8c

Delete chrome/app/theme/chromium/product_logo.svg

9689206

Add files via upload

16af7fa

Delete chrome/app/theme/chromium/product_logo_24.png

36c9540

Delete chrome/app/theme/chromium/product_logo_128.png

7a924e8

Delete chrome/app/theme/chromium/product_logo_256.png

86027b6

Delete chrome/app/theme/chromium/product_logo_48.png

30bf4f6

Delete chrome/app/theme/chromium/product_logo_64.png

a50a808

Add files via upload

5468908

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First Pull Req #203

First Pull Req #203

Tanvi-Chaudhari commented Nov 14, 2023

google-cla bot commented Nov 14, 2023

First Pull Req #203

Are you sure you want to change the base?

First Pull Req #203

Conversation

Tanvi-Chaudhari commented Nov 14, 2023

google-cla bot commented Nov 14, 2023