New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the typo to improve the readability. #199
Open
aziyatali
wants to merge
2
commits into
chromium:main
Choose a base branch
from
aziyatali:aziyatali-patch1
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
…112.0.5615.13-r1 to 112-5563.31-1677502748-benchmark-112.0.5615.14-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I65577bb9d9d0fa198c3cc6b4e27c629d5b78392d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4310680 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5615@{chromium#199} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Roll Chrome Win64 PGO profile from chrome-win64-6045-1696824919-59242d05d28d68e29014adee6b104fa646e32049.profdata to chrome-win64-6045-1696852631-5f4db7595fb9784401d39925e05435280bea75be.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m119.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I14a3c7b10bcc473887e0eb8e67f9a800764f871a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4922032 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#199} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori
pushed a commit
to Pissandshittium/pissandshittium
that referenced
this pull request
Dec 8, 2023
…120.0.6099.10-r1 to 120-6085.0-1698659522-benchmark-120.0.6099.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia2bd353ae3e584beb246c1204fd83c37fc5b8c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006748 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{chromium#199} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
Roll Chrome Win64 PGO profile from chrome-win64-6167-1702228404-76a017af3fb71a007331808a66d990d2edfb4791.profdata to chrome-win64-6167-1702246941-84c9e0a86362d8e7e5167c89d631ad44b09b7403.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iab2f49a83525dfb671fbfabe3b8bfba73d8b96b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5108383 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#199} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 10, 2024
Commits rolled: https://chromium.googlesource.com/v8/v8.git/+log/c3f31220d0e5..641c7c3a2b4d Generated by: go/bbid/8770170145927311201 Change-Id: Ic7b7a8e929984c188e8208c3a2ca7a9032769c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4858338 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5993@{#199} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
aarongable
pushed a commit
that referenced
this pull request
Jan 28, 2024
Automatic update for 2024-01-28 UTC Change-Id: I93fe5a519f3d88e7aa96f220eebae3e6cfac7518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5243305 Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Cr-Commit-Position: refs/branch-heads/6261@{#199} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
ecotopian
pushed a commit
to ecosia/chromium-android-browser
that referenced
this pull request
Feb 12, 2024
… counter This use counter is required for the launch of the DisableThirdPartyStoragePartitioning deprecation trial. It allows us to see how many times the deprecation trial is requested to be enabled. (cherry picked from commit 8e6659c) Bug: 1412821 Change-Id: Ie34de225e1d1726dfb7f3fa7920f08fcc20874f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219618 Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Kyra Seevers <kyraseevers@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1101102} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4225152 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{chromium#199} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable
pushed a commit
that referenced
this pull request
Feb 27, 2024
Uploaded by https://ci.chromium.org/b/8754979087550648529 Change-Id: I33ee7c49ff8206b0493a58853bf1b69a134c5f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5326643 Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6312@{#199} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
gcjenkinson
pushed a commit
to chromium-cheri/chromium
that referenced
this pull request
Mar 15, 2024
Roll Chrome Win32 PGO profile from chrome-win32-5790-1685532515-6ad0b701e8d6dfb4d6d81e52fb77c6b85a1ffbdc.profdata to chrome-win32-5790-1685553847-f222aab09804eb16279a1be58f9dd310be3898e7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m115.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1a2e8f5ad221fa6742912a44acbe282b3078989b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4577639 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790@{chromium#199} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
NaaeemMalik
pushed a commit
to SoftwarePrince/Egon-Chromium
that referenced
this pull request
Mar 22, 2024
Plumb the UseDeviceTheme functions from the CustomizeChrome pages to ThemeService. Setting any other theme implicilty clears the setting. The toggle is restricted to ChromeOS right now. (cherry picked from commit eb4ee9f) Bug: chromium:1444588 Change-Id: Ia101fc848b0b098ac4ebb7be04952b01bd0560df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4754964 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Sean Kau <skau@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1183326} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4781836 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938@{chromium#199} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable
pushed a commit
that referenced
this pull request
Mar 25, 2024
Roll src/v8 in M124 from 0ce213ae3187 to 08addf7beea2 Commits rolled: https://chromium.googlesource.com/v8/v8.git/+log/0ce213ae3187..08addf7beea2 Generated by: http://go/bbid/8752494297384449217 Change-Id: I76b9dc4772a91d61f4c49a37b1a7ee647f62745e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5391390 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#199} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
Apr 22, 2024
…125.0.6422.9-r1 to 125-6367.24-1713181437-benchmark-125.0.6422.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-chromium-beta Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: mobiletc-prebuild@google.com Change-Id: Ieb431d4204030f7d9c2d227a7a65a02f54127727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5470935 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#199} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.