Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to fix: #1493929 #197

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

try to fix: #1493929 #197

wants to merge 8 commits into from

Conversation

hjanuschka
Copy link
Contributor

@hjanuschka hjanuschka commented Oct 22, 2023 •
edited

@google-cla
Copy link

google-cla bot commented Oct 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hjanuschka
Fix rendering issues caused by missing render elements
bcd723e
@hjanuschka
Merge branch 'main' into hja_render
99a7486
@hjanuschka
Address Missing Re-Render for Floating Elements
1819a9f 
This commit partially reverts a previous refactor that inadvertently bypassed the re-rendering process for floating elements.
trflynn89 pushed a commit to RebelBrowser/rebel that referenced this pull request Oct 26, 2023
[iOS] Add description to DCHECK in -[SceneController teardownUI]
810d469 
As a follow-up of http://crrev.com/c/4802371, this patch adds
the sign-in coordinator description to the DCHECK log.

This patch will be cherry-picked to M118.

This will help to understand:
http://crbug.com/1478336
http://crbug.com/1474122

(cherry picked from commit 894fe24)

Fixed: 1479553
Change-Id: I75a084bba2976875f6ce2ad8fe67800089edf74f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4846598
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1194007}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4851293
Cr-Commit-Position: refs/branch-heads/5993@{chromium#197}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
[lacros skew tests] Refresh skew tests for M113 M112
c719e4a 
This CL updates the ash version ['113.0.5629.0', '112.0.5615.9'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.

If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org.

R=rubber-stamper@appspot.gserviceaccount.com

Bug: None
Change-Id: I6732b10e27c5d634864923af8f7e2ae44a62ae6e
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4308074
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5615@{chromium#197}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
Roll Amd64 AFDO from 119.0.6045.13_rc-r1-merged to 119.0.6045.15_rc-r…
032647f 
…1-merged

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I04d64f46fc1e4601455d482ee273b210293e70f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4921713
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#197}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori pushed a commit to Pissandshittium/pissandshittium that referenced this pull request Dec 8, 2023
Roll ChromeOS Arm Experimental AFDO profile from 120-6085.0-169865952…
1f1a861 
…2-benchmark-120.0.6099.9-r1 to 120-6085.0-1698659522-benchmark-120.0.6099.11-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-arm-exp-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ic8112135c09f9a74d1a1383adbc246fa8f16178c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006746
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{chromium#197}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 6, 2024
Roll Chrome Mac PGO Profile
94fca6e 
Roll Chrome Mac PGO profile from chrome-mac-6167-1702228404-cf34c0ebdc53c6aea0cb97eb2006bbee255ae157.profdata to chrome-mac-6167-1702246941-2705255477c71e8f9018d89891aae23dfabea4b2.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m121.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Id95d17914eb2d3bc66c7755666b76e998fd3acdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5108606
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6167@{#197}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable pushed a commit that referenced this pull request Jan 28, 2024
Roll Chrome Win64 PGO Profile
37a041b 
Roll Chrome Win64 PGO profile from chrome-win64-6261-1706409613-43f42327b86bdeca8bed88a3e425620aaed7e097.profdata to chrome-win64-6261-1706433588-e185a8cb5310c8830a68c800cd1bd7993d7cdbfc.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m122.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ifa56612974c5098a73585ffe6a746c140c86062b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5243492
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6261@{#197}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
ecotopian pushed a commit to ecosia/chromium-android-browser that referenced this pull request Feb 12, 2024
[ios] Call updateScrolledToMinimumHeight with updateAdditionalOffset
8104579 
-updateScrolledToMinimumHeight needs to be called in
-updateFeedInsetsForContentAbove since `additionalOffset` is updated,
and scrolledToMinimumHeight's state depends on that value.

-updateNTPLayout calls -updateAdditionalOffset and
-updateScrolledToMinimumHeight now, so there is no need for the
duplicate calls in viewWillLayoutSubviews.

FeedDelegate's -returnToRecentTabWasAdded API is not used, so it is
removed.

(cherry picked from commit 0b8f4af)

Bug: 1409654
Change-Id: I3413e329fa58e128df4ad53e1013876a14a3039d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4189639
Reviewed-by: Adam Arcaro <adamta@google.com>
Reviewed-by: Scott Yoder <scottyoder@google.com>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1099327}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4220726
Cr-Commit-Position: refs/branch-heads/5563@{chromium#197}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable pushed a commit that referenced this pull request Feb 27, 2024
Roll src/internal in M123 from f23ada0aee4e to 523f6707a395
afa746c 
Commits rolled:
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f23ada0aee4e..523f6707a395

Generated by: go/bbid/8754940417211160177

Change-Id: I0a6b477eeb591508900953aecc6ddf71611cb443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5320158
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6312@{#197}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
gcjenkinson pushed a commit to chromium-cheri/chromium that referenced this pull request Mar 15, 2024
Roll Chrome Mac PGO Profile
cb9736c 
Roll Chrome Mac PGO profile from chrome-mac-5790-1685532515-55252dd20e89fba700cd3fe9ebedf5ef1dc50301.profdata to chrome-mac-5790-1685553847-7ff15a6d2fcf961670bd4120fc272136585b92f1.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m115.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I9dc2f1d1310af94aebd5ec6fc1981481218cd7f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4577384
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5790@{chromium#197}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
NaaeemMalik pushed a commit to SoftwarePrince/Egon-Chromium that referenced this pull request Mar 22, 2024
Roll DEPS for refs/branch-heads/5938
0cf19e7 
Change-Id: If50f8f1683e047e288853ce2e86f4d87c9725738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4783991
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5938@{chromium#197}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable pushed a commit that referenced this pull request Mar 25, 2024
@ddacw
[iOS] Add AADC History Sync buttons metrics
0fdcd94 
This CL mirrors crrev.com/c/5368857 (desktop).

(cherry picked from commit aa3c436)

Bug: 330677698, 325435359
Change-Id: Ic7d83ae526ee4edc819e383fd3e2ba4c0f9f32d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5378628
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Duong Dac <ddac@chromium.org>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1275578}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5385443
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/branch-heads/6367@{#197}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 22, 2024
Roll Chrome Linux PGO Profile
a1c2e62 
Roll Chrome Linux PGO profile from chrome-linux-6422-1713733953-ead6cf160d5ba8362bfe80b9fd2330d2f168f37c-e0be679e16b5bf10a1f284e3ddc1a9b4a84a8ab0.profdata to chrome-linux-6422-1713763964-2a844d3a248748bda77afaa0084d22948c767513-122fe18cfe278bbe2b13f48c280bc843749ab114.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m125.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie82d31abb862a9ad72b87a9328439e7ffcb4c2fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471148
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6422@{#197}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@hjanuschka