Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in night_mode.md #196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typo in night_mode.md #196

wants to merge 1 commit into from

Conversation

wandersiemers
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Oct 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

trflynn89 pushed a commit to RebelBrowser/rebel that referenced this pull request Oct 26, 2023
@khushalsagar
flags: Re-enable ViewTransitionOnNavigation
eea22c8 
R=vmpstr@chromium.org

(cherry picked from commit 4126528)

Fixed: 1479704
Change-Id: Iaf80fe03218d85358d44b160661ef30ce529065f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4848187
Auto-Submit: Khushal Sagar <khushalsagar@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1193305}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4856645
Cr-Commit-Position: refs/branch-heads/5993@{chromium#196}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
@skylab-tests-roller
[skylab_tests] Update skylab tests cros img version
da8a58b 
This cl only affect Lacros on-device config builders like
lacros-amd64-generic-chrome-skylab. This cl will certainly NOT affect
linux-lacros builders(linux-lacros-tester-rel, linux-lacros-rel, etc)
or any other platforms.
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.

If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org,
yjt@google.com.


R=rubber-stamper@appspot.gserviceaccount.com

Requires-Testing: True
Change-Id: Id0381695dac7d5a2542f32acf6196e5bdcb63edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4310441
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5615@{chromium#196}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
Automated Commit: LKGM 15633.9.0 for chromeos.
2a23fda 
Uploaded by https://ci.chromium.org/b/8767757015866584257

Change-Id: I303b7c5e781f392f1f864e3df46e1d95968381d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4921716
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#196}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori pushed a commit to Pissandshittium/pissandshittium that referenced this pull request Dec 8, 2023
Roll Chrome Linux PGO Profile
97bc469 
Roll Chrome Linux PGO profile from chrome-linux-6099-1699153565-d1581ebf1020bd8c203efe35a782ffca62660786.profdata to chrome-linux-6099-1699180505-7f7d734b9c97c956420736700f3328fd9c1a1312.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m120.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I85164cc57ceff8a9f71c88a6c990be3656c1ca70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006310
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{chromium#196}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 6, 2024
Incrementing VERSION to 121.0.6167.14
25e4f3b 
Change-Id: I20adcb92c6d8b4c41bbe0964b3328a7209565aea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5107685
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6167@{#196}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable pushed a commit that referenced this pull request Jan 28, 2024
Updating XTBs based on .GRDs from branch 6261
aca5c13 
Change-Id: I061450129daf1e948a565eb89c1f5a365bd4ba22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237784
Auto-Submit: Ben Mason <benmason@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6261@{#196}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
ecotopian pushed a commit to ecosia/chromium-android-browser that referenced this pull request Feb 12, 2024
[Merge 111] User can't delete blocked sites for password grouping
3b0acc3 
- Add logic to remove blocked site from cache.
- Convert PasswordForm vector to CredentialUIEntry vector.

(cherry picked from commit 433a482)

Bug: 1412142
Change-Id: I7a4252a40e35117f051c600d7ae963f54049e054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4215772
Commit-Queue: Veronique Nguyen <veronguyen@google.com>
Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1101082}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219237
Cr-Commit-Position: refs/branch-heads/5563@{chromium#196}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable pushed a commit that referenced this pull request Feb 27, 2024
[iOS] Add UI layer Save to Drive metrics
c593bdd 
(cherry picked from commit 8689db7)

This cherry-pick also fixes the definition of metrics by including the
variants missing from the original change.

Change-Id: I24df8406d32ab6a9aa6df78cc8a914b682e7295d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5280744
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Quentin Pubert <qpubert@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1264575}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5317647
Cr-Commit-Position: refs/branch-heads/6312@{#196}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
gcjenkinson pushed a commit to chromium-cheri/chromium that referenced this pull request Mar 15, 2024
Roll Chrome Win64 PGO Profile
b9eac49 
Roll Chrome Win64 PGO profile from chrome-win64-5790-1685532515-f57f2b767c3457aeea1d7ed1affa32d3251b283a.profdata to chrome-win64-5790-1685553847-ca32191a15281b85d6b677c801d86b1efce3890d.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m115.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I88508cd99ab712a0d20ee85e5d2ed9d1f9a3d349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576489
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5790@{chromium#196}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
NaaeemMalik pushed a commit to SoftwarePrince/Egon-Chromium that referenced this pull request Mar 22, 2024
Quick Delete: Add more metrics
f02d309 
Add metrics to record tab switcher entry point, more options button
click, search history disambiguation link clicks and time period
selections.

(cherry picked from commit b760950)

Bug: 1472819
Change-Id: I8cbfda766c83ab125bafccbefb2350d28849507f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4774461
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Auto-Submit: Zaina Al-Mashni <zalmashni@google.com>
Commit-Queue: Zaina Al-Mashni <zalmashni@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1183411}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4777762
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/branch-heads/5938@{chromium#196}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable pushed a commit that referenced this pull request Mar 25, 2024
[iOS] Fix ipad extra vertical space
a8c803f 
This patch makes sure the extra space on iPad goes at the bottom of
the view instead of the top.
There is no changes on iPhone.

This also fix a small issue on constraint. The bottom of the scroll
view should be attached to the top of the separator (the one that is
just above the button).

This patch needs to be merge into M124.

Before:
https://drive.google.com/file/d/1Qj5tL14SlxPe7JHVpnyXVVGfyKKA8n4Q/view?resourcekey=0-3f86qDsn2XQwZlYjURMnVQ
After:
https://drive.google.com/file/d/1oOu7n7-MXDvsxv4NJg4ZjgfkbfYjVquR/view?resourcekey=0-NP-f-bJY_RhD3yslI92V-Q


(cherry picked from commit e97c43d)

Fixed: 330713313
Change-Id: Iaca0fd933c676c8f18529931ad6e81930d17fb89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5383437
Commit-Queue: Samar Chehade-Lepleux <samarchehade@google.com>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Samar Chehade-Lepleux <samarchehade@google.com>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1276304}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388680
Cr-Commit-Position: refs/branch-heads/6367@{#196}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 22, 2024
Roll Chrome Linux PGO Profile
122fe18 
Roll Chrome Linux PGO profile from chrome-linux-6422-1713718539-b2c7d6cd6777c2c598f2ac900aab9d2edac5fcc6-efce24656591a49aa90c8f7a853990eae3147824.profdata to chrome-linux-6422-1713733953-ead6cf160d5ba8362bfe80b9fd2330d2f168f37c-e0be679e16b5bf10a1f284e3ddc1a9b4a84a8ab0.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m125.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Iddedf13a015ca39bcd9e7a6afedf546a48d9a1c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471082
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6422@{#196}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@wandersiemers