New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md Broken Image links fixed (#1) #194
Open
muhammad-fiaz
wants to merge
15
commits into
chromium:main
Choose a base branch
from
muhammad-fiaz:main
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md contains some grammar corrections that got fixed and the logo of Chromium broken link was fixed
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
trflynn89
pushed a commit
to RebelBrowser/rebel
that referenced
this pull request
Oct 26, 2023
This change adds a LocalState pref that keeps track of the number of parcel tracking module impressions since a Parcel Tracking freshness signal event. The pref will be reset to zero when it gets such an event. (cherry picked from commit f11bb6a) Bug: 1462664 Change-Id: I2e24c6c84c52b6e4e67f329347d45cab5b25046f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4833590 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Ritika Gupta <ritikagup@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1193108} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4854289 Commit-Queue: Ritika Gupta <ritikagup@google.com> Cr-Commit-Position: refs/branch-heads/5993@{chromium#194} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
… on" This fixes a bug where the recent items (from the last day) that may have been actioned on (viewed in the main view) in a previous Chrome session, still show up in the partial view upon restarting Chrome. We don't persist the "actioned on" bit to the history database, so assume that items loaded from history have already been actioned on. (cherry picked from commit 010ea64) Bug: 1418468 Change-Id: I2e4aa0bccc5eac4ca857fd49677840e9c1905890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4290057 Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1112227} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307696 Auto-Submit: Lily Chen <chlily@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/branch-heads/5615@{chromium#194} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Roll Chrome Win64 PGO profile from chrome-win64-6045-1696799779-8f1888f1ee310f64573cd685d5df68bca88977eb.profdata to chrome-win64-6045-1696824919-59242d05d28d68e29014adee6b104fa646e32049.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m119.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I113562dcba6a5539268e6ba607759fe65ced946d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4921651 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#194} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori
pushed a commit
to Pissandshittium/pissandshittium
that referenced
this pull request
Dec 8, 2023
Roll Chrome Win32 PGO profile from chrome-win32-6099-1699153565-50dc61d8b3ac8c72ad708146f44c99efaa82ac8f.profdata to chrome-win32-6099-1699180505-26b11c368c0600ad878b3a082f39b08eed042d8a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m120.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iaf1c6a9c89a34887edd72572efee6d1340d649b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006741 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{chromium#194} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
…rk-121.0.6167.11-r1 to 121-6126.0-1701688287-benchmark-121.0.6167.12-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: mobiletc-prebuild@google.com Change-Id: I1daec4808e1deba49f470928e1ea979ed90a86c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5108879 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#194} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 28, 2024
Roll Chrome Mac PGO profile from chrome-mac-6261-1706389012-144d1fe1818b83da77926648e77028ab7641dca5.profdata to chrome-mac-6261-1706409613-d6736e5862cd5af1addec73790e45c20f74717a3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m122.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I216c3a1ae675e914268ed6e36939ce072174d0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5243352 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#194} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
ecotopian
pushed a commit
to ecosia/chromium-android-browser
that referenced
this pull request
Feb 12, 2024
As a part of the larger initiative to allow the browser process access to the enabled/disabled state of Blink Runtime-Enabled Features (go/brefs), this CL creates the IPC mechanism with which the renderer process alerts the browser process of any changes to these BREF values. In particular, this interface will send a diff of feature values and the associated origin trial token(s) each time an origin trial feature is enabled. The browser side will compile and store these changes in the RuntimeFeatureStateReadContext once it can verify that the tokens received are valid, the feature received is a valid origin/deprecation trial, and that we expect to be able to have browser read/write access to that feature. Design Doc: https://docs.google.com/document/d/1cZCEbYkl-1fjfW4acyoBedZqBgdkWnHZX7pjkVw_94Q/edit?usp=sharing (cherry picked from commit 62911c1) Bug: 1377000, 1412502 Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I605c9800f02dbb7f9a6fb07cb36bb59728a66a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4080618 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Kyra Seevers <kyraseevers@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1100514} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219586 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{chromium#194} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable
pushed a commit
that referenced
this pull request
Feb 27, 2024
… IPH. Previously it was only for user who acts upon the 1st step, proving to be almost never happening. Change it to include the timeout case to be more effective. Bug: b/326243402 (cherry picked from commit dc3631c) Change-Id: Ib9948b9ed3c0e7ea82263eb96382dc63c34d0a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314221 Reviewed-by: Hira Mahmood <hiramahmood@google.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Huiting Yu <huitingyu@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1264461} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324040 Cr-Commit-Position: refs/branch-heads/6312@{#194} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
gcjenkinson
pushed a commit
to chromium-cheri/chromium
that referenced
this pull request
Mar 15, 2024
- Standardise RadioButtonWithDescriptionAndAuxButton a11y behaviour. Current Talkback speech: - Radio button "<title>, <description> for Expand <auxButtonContentDescription>" - Aux button "Expand <auxButtonContentDescription>" New Talkback speech: - Radio button "<title>, <description>" - Aux button "Expand, Button for <title>" (cherry picked from commit a9d741d) Bug: 1446122 Change-Id: I4488b3f3427ffe9a0c6521c8779d17e7f8a25c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4570621 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Rubin Deliallisi <rubindl@chromium.org> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1150610} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574907 Commit-Queue: Theresa Sullivan <twellington@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Rubin Deliallisi <rubindl@chromium.org> Cr-Commit-Position: refs/branch-heads/5790@{chromium#194} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
NaaeemMalik
pushed a commit
to SoftwarePrince/Egon-Chromium
that referenced
this pull request
Mar 22, 2024
Roll Chrome Linux PGO profile from chrome-linux-5938-1692160680-8674588a63e9eb3e109b677a1e3e2c28400063c3.profdata to chrome-linux-5938-1692186851-4c464c5a497fa12c4d9d364da19385b44f0335b0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m117.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I441f59eb5090e7d173863924bb86d6a69bdf288a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4783691 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938@{chromium#194} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit 30ae99b) Bug: 329443056 Change-Id: I8b25473883a298a78a5a509b9065a3d1d825ac62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5371733 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Quentin Pubert <qpubert@google.com> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1275489} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388048 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/branch-heads/6367@{#194} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
Apr 22, 2024
Roll Chrome Win64 PGO profile from chrome-win64-6422-1713718539-fce0c68d2bd8c81ea82468ac61ff9a9667d7b2b4-efce24656591a49aa90c8f7a853990eae3147824.profdata to chrome-win64-6422-1713733953-dbafb477922562c8337d74c2d25aae63d0c81e1c-e0be679e16b5bf10a1f284e3ddc1a9b4a84a8ab0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m125.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6bdb47cabf16b919b31791830606203b83b5a70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469973 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#194} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.md contains some grammar corrections that got fixed and the logo of Chromium broken link was fixed