Fix 🐛: Issue Overlapping Bug #32399 #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix 🐛: Issue Overlapping Bug #32399
harshul786
changed the title
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Sep 10, 2023
Roll Chrome Win32 PGO profile from chrome-win32-5938-1692160680-32f83af782b6cc5f6bf4db674a30acc347201285.profdata to chrome-win32-5938-1692186851-7d438ffb7ae6555e9e6187b44c0999cd7f31a2b0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m117.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib07d6ca9a1636f23302489f5486b66b5508bc973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4783648 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938@{#193} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
trflynn89
pushed a commit
to RebelBrowser/rebel
that referenced
this pull request
Oct 26, 2023
…h DUMP_WILL_BE_CHECK This CL is part of the fix [1] that was proposed to deal with the increasing number of crashes related to child coordinators. This CL converts CHECKs and DCHECKs that have been failing in relation to the issue with DUMP_WILL_BE_CHECK. The goal is to get reports from those on Stable without crashing the app. We'll be able to get a better signal on how often these fail because the request to restart the child coordinator happens before the previous instance had enough time to be cleaned up vs other causes. [1] https://docs.google.com/document/d/1s3d2aQNYIAuZJcEW2PWki-xzD44BwckFP8HSm3r5hoE/edit#heading=h.2px6trsn0jl1 (cherry picked from commit 0c8389f) Bug: 1464966 Bug: 1475266 Change-Id: Iaddee0e509491444bb72bfe441d0388124933d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4851425 Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Noémie St-Onge <noemies@google.com> Cr-Commit-Position: refs/branch-heads/5993@{chromium#193} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
This closes the partial bubble after 5 seconds with no user interaction. If the user hovers over the bubble in that time, the auto-close will be cancelled. (cherry picked from commit 828018c) Bug: 1420281 Change-Id: Ie863ef397d3435b7d4487a6b639f9213403c5713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4301869 Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1112486} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307098 Auto-Submit: Lily Chen <chlily@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/branch-heads/5615@{chromium#193} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Roll Chrome Mac PGO profile from chrome-mac-6045-1696799779-f4c3a65e1dbc5eb9d58b3dd0740f2eef08209541.profdata to chrome-mac-6045-1696824919-5c74c82294aa2c84be1e7f876ba6e4be72506443.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m119.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1d435d1120d204329ca2e63c068fa10f8a61d902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4921689 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#193} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori
pushed a commit
to Pissandshittium/pissandshittium
that referenced
this pull request
Dec 8, 2023
Automatic update for 2023-11-05 UTC Change-Id: Idf1756d08dfebfa39d18a8f9ad59a628202d74d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5004056 Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Cr-Commit-Position: refs/branch-heads/6099@{chromium#193} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
Roll Chrome Win32 PGO profile from chrome-win32-6167-1702199807-fe9c1bdcb6a188b04bfa41a854475e7f43613b93.profdata to chrome-win32-6167-1702228404-ebe517217ba94f447efe7ead6d6183aa520c2ed2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic465cd2dd604a5eaf3bfa708e3e09b64c6666990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5107264 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#193} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 28, 2024
Roll Chrome Linux PGO profile from chrome-linux-6261-1706389012-6553190b72fbc76b72e45c523d9f2db912478d05.profdata to chrome-linux-6261-1706409613-d520ec55a99952b6bf323cbc8b59435860db1e01.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m122.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icc6a1be75951038cae2ac17059fae3abaefa8c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241489 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#193} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
ecotopian
pushed a commit
to ecosia/chromium-android-browser
that referenced
this pull request
Feb 12, 2024
When clicking 'Got it' the list of unused site permissions is cleared and not shown again. On Undo the list is restored. This change adds the CPP side. The TS/UI side already landed. (cherry picked from commit 72d9ff1) Bug: 1345920, 1411718 Change-Id: Id18f531e8a7901e1c7348e21aad0d5435fe224f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4166069 Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org> Commit-Queue: Eduard Hez <ehez@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Kamila Hasanbega <hkamila@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1098372} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4218231 Reviewed-by: Illia Klimov <elklm@chromium.org> Reviewed-by: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/branch-heads/5563@{chromium#193} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable
pushed a commit
that referenced
this pull request
Feb 27, 2024
Commits rolled: https://webrtc.googlesource.com/src.git/+log/c026167f59bc..45e49ef5371e Generated by: go/bbid/8754947967337332417 Change-Id: I2d350ebc1a6c192a292e23efefa11a9e2178da7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324523 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6312@{#193} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
gcjenkinson
pushed a commit
to chromium-cheri/chromium
that referenced
this pull request
Mar 15, 2024
(cherry picked from commit a19720b) Bug: 1446168 Change-Id: Ibd79ebb0b7f76116e428588306ace5238ea01b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571021 Reviewed-by: Rainhard Findling <rainhard@chromium.org> Commit-Queue: Rubin Deliallisi <rubindl@chromium.org> Auto-Submit: Rubin Deliallisi <rubindl@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1150467} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4570898 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790@{chromium#193} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
aarongable
pushed a commit
that referenced
this pull request
Mar 25, 2024
This is also happening on Android (https://crrev.com/c/5339955) due to the Perfetto client SDK migration. See attached bug for details. (cherry picked from commit e29b8f5) Bug: crbug.com/328832459 Change-Id: I6822016d2b6364fb1fa41d73caa0743c475bf891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5379322 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Auto-Submit: David Song <wintermelons@google.com> Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1276129} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5386441 Cr-Commit-Position: refs/branch-heads/6367@{#193} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
Apr 22, 2024
This CL updates the ash version ['126.0.6432.0'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I1ade1c83caa232f60205d727acd78be055157ce2 Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463087 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#193} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is mentioned in: brave/brave-browser/issues/32399
before resolved video is mentioned in the issue,
after resolved:
Screen.Recording.2023-09-09.at.2.34.31.PM.MOV