Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting the kDisableWindows10CustomTitlebar switch removal #188

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Reverting the kDisableWindows10CustomTitlebar switch removal #188

wants to merge 8 commits into from

Conversation

logoffon
Copy link

@logoffon logoffon commented Jul 29, 2023 •
edited

The recent removal of --disable-windows10-custom-titlebar switch meant that Chromium and its derivatives can no longer have consistent appearance for users with visual style/theme customization (such as AeroGlass, WindowBlinds, MicaForEveryone, etc.). There is simply no reason to draw a custom title bar when the native one can do just fine, and conforms to whatever the theme the user is set.

@logoffon
Update theme_helper_win.cc
0eaad9f 
Reverting the kDisableWindows10CustomTitlebar switch removal
@logoffon
Update native_chrome_color_mixer_win.cc
5258b65 
Reverting the kDisableWindows10CustomTitlebar switch removal
@logoffon
Update browser_frame_view_win.cc
fe0913b 
Reverting the kDisableWindows10CustomTitlebar switch removal
@logoffon
Update browser_frame_view_win.h
77f1b46 
Reverting the kDisableWindows10CustomTitlebar switch removal
@logoffon
Update titlebar_config.cc
a199ddb 
Reverting the kDisableWindows10CustomTitlebar switch removal
@logoffon
Update titlebar_config.h
530d7ce 
Reverting the kDisableWindows10CustomTitlebar switch removal
@logoffon
Update chrome_switches.cc
a134f83 
Reverting the kDisableWindows10CustomTitlebar switch removal
@logoffon
Update chrome_switches.h
abad711 
Reverting the kDisableWindows10CustomTitlebar switch removal
aetota61 pushed a commit to monkbrowser/monk-browser that referenced this pull request Aug 2, 2023
@haoliuk
Set receive_header_start only for main frame document
bd1eb06 
This is to fix a bug in a previous CL.
https://chromium-review.googlesource.com/c/chromium/src/+/4476487. The
receive_header_start_ of the PageLoadTracker object is set for each
resource. We want the field to hold the value of the main frame document
only.

(cherry picked from commit b682b61)

Bug: 1431906
Change-Id: Ifc76f40c1790f626b9aacbece785010c4d6e0710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562797
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Hao Liu <haoliuk@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1150323}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575844
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5790@{chromium#188}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
l0hn pushed a commit to protectednet/hopium that referenced this pull request Aug 23, 2023
Incrementing VERSION to 116.0.5845.11
e28ed98 
Change-Id: I5b8c93407ff1a439c2f21a04a00366ddb63712aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4653310
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5845@{chromium#188}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
blueboxd referenced this pull request in blueboxd/chromium-legacy Sep 10, 2023
[iOS] Don't trigger reauth during device restore
4158ced 
Reauth prompt sign-in should not set when a device restore is detected.

(cherry picked from commit 8a45922)

Fixed: 1471875
Change-Id: I3f476fce4d68359492b7506342baceadd27574de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4771755
Reviewed-by: Scott Yoder <scottyoder@google.com>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Scott Yoder <scottyoder@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1182547}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4783427
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Menghan Yang <myuu@google.com>
Commit-Queue: Menghan Yang <myuu@google.com>
Cr-Commit-Position: refs/branch-heads/5938@{#188}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
@teknixstuff
Copy link

I'd like this reverted too!

teknixstuff referenced this pull request Sep 21, 2023
@jloeffler4
[win] Remove the kDisableWindows10CustomTitlebar switch
d6581b4 
This CL removes the obsolete --disable-windows10-custom-titlebar switch
and some related logic.

Bug: 1059931
Change-Id: I86c79e43c077e3aa5d82d858de7c78c78ee0c629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4534461
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1145012}
trflynn89 pushed a commit to RebelBrowser/rebel that referenced this pull request Oct 26, 2023
Choose closest covering position for large snap areas
799e733 
This patch modifies the logic to find snap positions so that when a scroller is scrolled to a position which only partially covers a snap
area larger than itself, if it snaps to this large snap area, it snaps
to the nearest boundary of that snap area where the snap area covers the
snap port, rather than doing a jump to honor the specified scroll-snap-align.

Below are a few notes about changes made to tests:

snap-area-overflow-boundary.html is corrected so that both test cases
correctly verify the scroll offset when snapped to the lower element.
The scroll amount in the second test case is also adjusted to ensure
it is enough to snap to the lower div.

The expectations at the end of
scroll-on-large-element-not-covering-snapport.tentative.html are
updated to account for choosing a snap position different from the
scroll-snap-align-specified position for snap areas larger than their
snapports.

scroll-snap-type-on-root-element.html is updated to account for
scrollbar width since snapping to the right edge of the target is
valid.

This patch picks new programmatic scroll offsets for
snap-to-visible-areas-margin-both.html so that the top-left of
intersection of the right-top and left-bottom targets' scroll-margins
is closer than the bottom-right of the intersection.

scrollend-with-snap-on-fractional-offset.html and
scroll-start-with-scroll-snap-tentative.html are adjusted to use snap
area sizes that don't cover the snap port.

(cherry picked from commit 0295a2c)

Bug: 1420762
Change-Id: I72d18b8ca44ea5aef015e59b67e4de34a66d8a1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4806971
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1193634}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4853949
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/branch-heads/5993@{chromium#188}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
@teknixstuff
Copy link

@logoffon you might need to send this to the chromium mailing list, since github is just a mirror of the source and not where actual work happens.

vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
@nickburris
[M112][PaymentRequest] Fix payments view accessibility visibility
32a741a 
(cherry picked from commit a73e70d)

This ensures that invisible payments views are ignored in accessibility
contexts such as a screen reader. See the bug for more context, in
summary we used to rely on screen readers ignoring invisible elements,
which is no longer the case.

- Behind the PaymentHandlerMinimalHeaderUX feature, the finished
  progress bar which is used as a separator is set to ignored once it's
  done loading. The origin label is also set to accessibility focusable.
- The processing spinner, present and invisible on most payment sheets,
  is set to ignored when invisible.
- Hidden payment sheets, made invisible within a stack of payment sheet
  views used for animation, are set to ignored when invisible.

Bug: 1418659, 1420720
Change-Id: I54d43bf3de29b84941c6a0a906c41139df0e4cf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4294863
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1112179}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4304359
Cr-Commit-Position: refs/branch-heads/5615@{chromium#188}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
Roll Chrome Mac PGO Profile
06cfc99 
Roll Chrome Mac PGO profile from chrome-mac-6045-1696782300-7d3207835829d5445a6f3b9508db23c5e499d534.profdata to chrome-mac-6045-1696799779-f4c3a65e1dbc5eb9d58b3dd0740f2eef08209541.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m119.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I5ce710cc1ee1d49205248c29721a3c1e43a6a87b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4921360
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#188}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori pushed a commit to Pissandshittium/pissandshittium that referenced this pull request Dec 8, 2023
Roll Chrome Win64 PGO Profile
7b09f16 
Roll Chrome Win64 PGO profile from chrome-win64-6099-1699132967-a4fcdc4c61ea96c2874c640caf3fd33966990d03.profdata to chrome-win64-6099-1699153565-9789b673a4ee5ccda22b69e54780ad19be01b709.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m120.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Id83ad388e5ed7cbd010f56dc7e73254fc361d8fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006305
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{chromium#188}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 6, 2024
Roll ChromeOS Arm AFDO profile from 121-6126.0-1701694528-benchmark-1…
b21ba4d 
…21.0.6167.11-r1 to 121-6126.0-1701694528-benchmark-121.0.6167.12-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-arm-chromium-beta
Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: mobiletc-prebuild@google.com
Change-Id: I087719394242563e3761482675cf1e7cab2d3723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5107263
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6167@{#188}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
@arukateru
Copy link

I also highly suggest to add this back, there is a very significant number of people who use third-party themes on Windows

aarongable pushed a commit that referenced this pull request Jan 28, 2024
Incrementing VERSION to 122.0.6261.12
0359548 
Change-Id: Ie14d155ad9f1958fb06170ba934702c8309598d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241751
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6261@{#188}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
ecotopian pushed a commit to ecosia/chromium-android-browser that referenced this pull request Feb 12, 2024
[M111][Privacy Sandbox] Update Ad Privacy icon on Privacy settings page
af62fb4 
Screenshot: https://crbug.com/1412734#c1

(cherry picked from commit 238548c)

Bug: 1412734
Change-Id: I021db31d9d584beb6ab0421523162a2ea5ccf1e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4221434
Commit-Queue: Gabriel Oliveira <gabolvr@google.com>
Reviewed-by: Olesia Marukhno <olesiamarukhno@google.com>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1101004}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4224431
Auto-Submit: Gabriel Oliveira <gabolvr@google.com>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/branch-heads/5563@{chromium#188}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable pushed a commit that referenced this pull request Feb 27, 2024
[M123]Add split logic with feature flag controlled.
6485eda 
Split the queued requests to smaller BatchedTrustedSignalsRequest by
precheck URL length with limit in each request for both trusted bidder
and seller signals update.

Use a feature flag kFledgeSplitTrustedSignalsFetchingURL to control it,
which is disabled by default.

Github: WICG/turtledove#767

(cherry picked from https://chromium-review.googlesource.com/c/chromium/src/+/5277387 commit 72e20be)

(cherry picked from commit 72e20be)

Bug: 324416012
Change-Id: I92b7077ae9e4b837ee65fb9fc0fc26b02a153b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5277387
Reviewed-by: mmenke <mmenke@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Tianyang Xu <xtlsheep@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1264576}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321213
Commit-Queue: Krishna Govind <govind@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6312@{#188}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
aarongable pushed a commit that referenced this pull request Mar 25, 2024
@elkurin
[M124] BrowserManager: Prepare lacros policy observers on each Launch
86072a8 
This CL prepares Lacros Policy observers on StarttIfNeeded and
ResumeLaunch explicitly instead of on profile created.

This is a quick fix for the ARC boot bug.

(cherry picked from commit ffb0b9c)

Bug: 329823550, 330659545
Change-Id: Ie7bccb1f14a864b20a1cba2ff042818b1bcf30c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5377682
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1276635}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5387504
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Auto-Submit: Eriko Kurimoto <elkurin@chromium.org>
Cr-Commit-Position: refs/branch-heads/6367@{#188}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 21, 2024
Automatic update from google3
efce246 
Automatic update for 2024-04-21 UTC

Change-Id: I552ca3a95f07def03fc06672bcac73995305719d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5470105
Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Cr-Commit-Position: refs/branch-heads/6422@{#188}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teknixstuff teknixstuff teknixstuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@logoffon @teknixstuff @arukateru