New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A peaceful protest againt Web Environment Integrity #187
base: main
Are you sure you want to change the base?
Conversation
A peaceful protest is underway against mega corporations attempting to impose DRM on the web, aiming to gain control over all content possible and making our lives worse
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This CL moves the base::Feature from content_features.h to a generated feature from runtime_enabled_features.json5. This means that the base::Feature can be default-enabled while the web API is controlled by the RuntimeFeature, which will still be default-disabled. An origin trial can enable the RuntimeFeature, which will allow full access to the API, provided the base::Feature is also enabled (see change to origin_trial_context.cc). Meanwhile, the base::Feature can be disabled through Finch as a kill-switch for the whole feature, and prevent origin trials from turning the feature on. Tests have been added to WebView test, as it allowed for easy spoofing of responses on a known origin. Bug: 1439945 Change-Id: Ifa0f5d4f5e0a0bf882dd1b0207698dddd6f71420 Fixed: b/278701736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4681552 Reviewed-by: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Pakkenberg <pbirk@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/main@{#1173344}
LGTM |
I will sign your pathetic CLA when Kent Walker publicly apologizes for retaliating against Claire Stapleton and Meredith Whittaker. How about that? |
Web Environment Integrity is named almost as honestly as The Patriot Act. This would be terrible for the web and for humanity. It must not be allowed. |
Don't forget to report this repo and @RupertBenWiser's "proposal" as malicious code.
Then uninstall / disable all Chromium browsers on your devices and replace them with Firefox and / or Fennec F-Droid. |
This page renders with errors on Chrome, I'm switching to Firefox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I don't understand; isn't Chromium supposed to be a version of Chrome that removes all the horrible corporate sins? |
You're thinking of ungoogled chromium. Chromium is controlled by Google. |
the conversation has been deleted? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏴☠️
LGTM, stops giving corporations with monopolistic power from trying to control everything. |
We add a chrome/ layer browser test to verify that site attestation works as intended for the Private Aggregation API in Shared Storage. (cherry picked from commit 7b435c1) Bug: 1448875,1455135,1218540 Change-Id: I78621e82b95c31a17889bbeae9d48ee5c305523f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4629671 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Alex Turner <alexmt@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1161325} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4654847 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/branch-heads/5845@{chromium#187} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
should exist in all browsers |
This reverts commit 71e07cd. Reason for revert: We found several system bugs with it. We reported to Apple, and will wait for them to fix it before we can have a good experience with full screen in Assistive Access. Original change's description: > Support full screen Assistive Access > > This CL adds support for showing Chrome in full screen when Assistive > Access is turned ON on the device. > > Bug: 1455090 > Change-Id: Ia57d375cd72a59195785260bc240285182eec9bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4700701 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Louis Romero <lpromero@google.com> > Cr-Commit-Position: refs/heads/main@{#1174622} (cherry picked from commit f39ae2c) Bug: 1455090 Change-Id: Ifbf2129c7d6ebd174dd877200a27ff7ef62d4291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4770476 Auto-Submit: Louis Romero <lpromero@google.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1182471} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4782286 Cr-Commit-Position: refs/branch-heads/5938@{#187} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Budget approved!
@@ -104,7 +104,7 @@ include_rules = [ | |||
|
|||
"+third_party/blink/public/common/client_hints/enabled_client_hints.h", | |||
"+third_party/blink/public/common/features.h", | |||
"+third_party/blink/public/common/features_generated.h", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a blatant attack on the fundamental privacy and security of all web users, intentionally and crudely bypassing W3C and directly attacking open web standards. By infiltrating the Chromium project like this, rather than trialling it in their own Chrome browser, Google are intentionally seeking to infect the vast majority of Internet users' devices without most of them even knowing, even if they intentionally boycott Google over this attack. If WEI is implemented in web browsers, all users will be held hostage by companies to only use approved devices in approved ways to access approved websites, being tracked and exploited while doing so. This is infinitely malicious in every way except holding a knife to someone's throat.
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it
The suggestions list doesn't need to scroll for suggestions to show beneath the keyboard, even though it is most of then the case. In certain situations, additional suggestions may be available below the keyboard, but their number may not make the list scrollable. This change relaxes the current restriction, permitting users to dismiss the keyboard even if suggestions list doesn't show. (cherry picked from commit 4300766) Change-Id: I478a17da65e01124b35d2e4a29f74538b00bc138 Fixed: 1479437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850684 Commit-Queue: Patrick Noland <pnoland@chromium.org> Auto-Submit: Tomasz Wiszkowski <ender@google.com> Reviewed-by: Patrick Noland <pnoland@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1194189} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4857107 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5993@{chromium#187} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
This change replaces a NOTREACHED check in -PromosManagerCoordinator::displayPromo with histogram logging. This change introduces two new histograms: - IOS.PromosManager.Promo.ForcedDisplayFailure, which logs when a promo that's forced for display (via Experimental settings toggle) has failed to display. - IOS.PromosManager.Promo.DisplayFailure, which logs when a promo has failed to display after being requested for display by the Promos Manager. Merge approved for M112: https://bugs.chromium.org/p/chromium/issues/detail?id=1421139#c9 (cherry picked from commit f17b818) Bug: 1408482,1421139 Change-Id: I2e7b1556369cafdf916dd88feabed4741a85c7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4289834 Commit-Queue: Benjamin Williams <bwwilliams@google.com> Reviewed-by: Ali Juma <ajuma@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1111634} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4308090 Cr-Commit-Position: refs/branch-heads/5615@{chromium#187} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
Roll Chrome Linux PGO profile from chrome-linux-6045-1696782300-7eb44163ea9d7fd89e120dff5096d1d4edc8607a.profdata to chrome-linux-6045-1696799779-0fdc4d9758111e449a6e6eeb3662a8399fbd126a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m119.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8ceac602f0e7669af7e3015892c04e0763f67be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4921181 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#187} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Roll Chrome Linux PGO profile from chrome-linux-6099-1699132967-f9a5d5f1b7cf4053045431aa454e5a5d1e8007c3.profdata to chrome-linux-6099-1699153565-d1581ebf1020bd8c203efe35a782ffca62660786.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m120.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iedf64be6fc93a17bbf47586f9194e9397d57c1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006085 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{chromium#187} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
Roll Chrome Win64 PGO profile from chrome-win64-6167-1702178078-cc0f230be8b45192735a7ae77dc5d1b540808b89.profdata to chrome-win64-6167-1702199807-4fe23266b46de32c4e70cc3d3118fbd386d9de46.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie96aa31d9ed2955868da09f8df5c012b6c552ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5107196 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#187} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
Roll Chrome Linux PGO profile from chrome-linux-6261-1706349784-98e18755d38167a9535c6ffaecfa597c63e9b064.profdata to chrome-linux-6261-1706370199-76b98d2158b80b316d556bc9a248187c1c42dfce.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m122.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iea7c744c5b45b5eb25df86754ed8096006b3b763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5242921 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#187} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
Temporary disable previewing generation suggestions on hover, until th bug with clearing the preview on declined password update is fixed. (cherry picked from commit ae5f437) Bug: 1410902 Change-Id: I1c8a6a61d59c993288ef41eaf3ef65513d93aa6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4209213 Reviewed-by: Dominic Battré <battre@chromium.org> Auto-Submit: Maria Kazinova <kazinova@google.com> Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1100397} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4224071 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{chromium#187} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
Before this CL, columns on chrome://predictors are colored with yellow (for preconnect-able entries whose confidnce is over 50) or green (for prerender-able entries whose confidence is over 80). However, this is not aligned with actual implementation of preconnect and prerender: we decreased the confidence thresholds to 30 for preconnect and 50 for prerender (see [1, 2]). To show correct information on chrome://predictors, this CL fixes the logic to determine column colors. [1]https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/predictors/autocomplete_action_predictor.cc;l=66-75;drc=669135887abc2cd3d611bd7edf913569d3586077 [2]https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/predictors/autocomplete_action_predictor.cc;l=290-299;drc=669135887abc2cd3d611bd7edf913569d3586077 (cherry picked from commit 0ad74c1) Bug: 40249821, 326299787 Change-Id: Ie690258135fc6c7cb921c3ada09aa018a1b38da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5312217 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Huanpo Lin <robertlin@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1263869} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321905 Cr-Commit-Position: refs/branch-heads/6312@{#187} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
Roll Chrome Win64 PGO profile from chrome-win64-6367-1711300579-f9e5c63c879bf4d218d84d8615230425e9dbd7d0-3679d13af631f30bc865a3664688c46b8881d406.profdata to chrome-win64-6367-1711324243-c17c8603366e04e901055a9ceccb7eba30528a72-6ac91b0d81050d473ed5734235b2f11ed934d4a2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m124.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I974a9e2fe8259f7ab4706d4faebdd49819f2f7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5390660 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#187} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
Change-Id: I39093f6022b1e890e363411dbc05cb1b9a0360bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466267 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#187} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
A peaceful protest is underway against mega corporations attempting to impose DRM on the web, aiming to gain control over all content possible and making our lives worse.