Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding comma #185

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adding comma #185

wants to merge 4 commits into from

Conversation

KUNDAN1334
Copy link

adding comma #180

aetota61 pushed a commit to monkbrowser/monk-browser that referenced this pull request Aug 2, 2023
Roll Chrome Win64 PGO Profile
e01444a 
Roll Chrome Win64 PGO profile from chrome-win64-5790-1685509565-a0f53d532eb5285d741d6ebd367b802bea69c54f.profdata to chrome-win64-5790-1685532515-f57f2b767c3457aeea1d7ed1affa32d3251b283a.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m115.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I75c4ed9b762546f80a6f161f61dd21d20402340f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576483
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5790@{chromium#185}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
l0hn pushed a commit to protectednet/hopium that referenced this pull request Aug 23, 2023
@randomascii
Fix arm64 Windows Rust triplet-mismatch errors
2a09d14 
(cherry picked from commit 38221aa)

Bug: 1455927
Change-Id: I961ca4c46a330fb44c4b1e2d4c14bc723b7ab53a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4647273
Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1162674}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4653686
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5845@{chromium#185}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
blueboxd referenced this pull request in blueboxd/chromium-legacy Sep 10, 2023
Roll v8 11.7 from 69685db936e8 to 7adb92fdafac (4 revisions)
9f38d71 
https://chromium.googlesource.com/v8/v8.git/+log/69685db936e8..7adb92fdafac

2023-08-16 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 11.7.439.4
2023-08-16 olivf@chromium.org Merged: [ic] Fix clone ic when the target has fewer inobject properties
2023-08-16 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 11.7.439.3
2023-08-16 olivf@chromium.org Merged: [maglev] Fix DeoptimizationData jsframe_count again

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-11-7-chromium-m117
Please CC liviurau@google.com,v8-waterfall-sheriff@grotations.appspotmail.com,vahl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in v8 11.7: https://bugs.chromium.org/p/v8/issues/entry
To file a bug in Chromium m117: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1471511,chromium:1472121
Tbr: v8-waterfall-sheriff@grotations.appspotmail.com
Change-Id: Ib620710872b57dac965ffeec541b8de5a7128402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4779966
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5938@{#185}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
trflynn89 pushed a commit to RebelBrowser/rebel that referenced this pull request Oct 26, 2023
Record LateFramesPercentage histogram for mirroring sessions
646e636 
At the end of a cast mirroring session, record the percentage of frames
that are late for Audio and Video types.

(cherry picked from commit cc10715)

Change-Id: Ia21b97ec6ced75b5661df5fc05304d2e436c704d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4848267
Reviewed-by: Evan Liu <evliu@google.com>
Commit-Queue: Benjamin Zielinski <bzielinski@google.com>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1193874}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4856276
Auto-Submit: Benjamin Zielinski <bzielinski@google.com>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/branch-heads/5993@{chromium#185}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
[M112] Use optional SafeRef to save RenderFrameHost in NavigationRequest
8cd2c2c 
This prevents use-after-free if NavigationRequests somehow still
points to an already-deleted RFH, which is currently possible (see bug).

Also converts usages of `render_frame_host_` to use the
GetRenderFrameHost() function to ensure that they are all called after
the final RenderFrameHost is picked for the navigation.

(cherry picked from commit 7b75ae3)

Bug: 1416916
Change-Id: Ieebcef424a5c79d13cc35e7781db013eaaac8150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4278923
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1112656}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4309939
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/branch-heads/5615@{chromium#185}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
Incrementing VERSION to 119.0.6045.16
c04527e 
Change-Id: I752b6ab1b0c46ea6888db9436c28590bf6653df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4917839
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#185}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori pushed a commit to Pissandshittium/pissandshittium that referenced this pull request Dec 8, 2023
Roll Chrome Win64 PGO Profile
13fc3b7 
Roll Chrome Win64 PGO profile from chrome-win64-6099-1699119607-b0e055f2f08120f7c9d0b36b66bf0964294f12aa.profdata to chrome-win64-6099-1699132967-a4fcdc4c61ea96c2874c640caf3fd33966990d03.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m120.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ieb1f438eb9d0165111964d160b6267ad406be27a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006547
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{chromium#185}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 6, 2024
Automatic update from google3
f0985d8 
Automatic update for 2023-12-10 UTC

Change-Id: Ia5e9e2a242392061f0e89d9e7e3bbbc56f4e463d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5104796
Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Cr-Commit-Position: refs/branch-heads/6167@{#185}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable pushed a commit that referenced this pull request Jan 27, 2024
[M122][CSC] Fix the killswitch
3012bbd 
Use a base::Feature killswitch that is distinct from the one
auto-generated to go with the OT token. Use the killswitch
to gracefully reject Captured Surface Control API calls
coming from an OT-enabled site if the killswitch is engaged.

Prior to this change, OT users who did not manually enable
the CapturedSurfaceControl base::Feature ran into
a render process crash (through a BadMessage).

Bug: 1521810, 1466247
Change-Id: I0c37d1409db365e548d6130a37ccc55c857cc52c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237671
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/branch-heads/6261@{#185}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
ecotopian pushed a commit to ecosia/chromium-android-browser that referenced this pull request Feb 12, 2024
Updating XTBs based on .GRDs from branch 5563
2d60762 
Change-Id: Ib5f74ece92087a7905b08612d263efca9658fd5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219247
Auto-Submit: Ben Mason <benmason@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5563@{chromium#185}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable pushed a commit that referenced this pull request Feb 27, 2024
[lacros skew tests] Refresh skew tests for M124 M123
9b8350d 
This CL updates the ash version ['124.0.6324.0', '123.0.6312.11'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.

If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org.

R=rubber-stamper@appspot.gserviceaccount.com

Bug: None
Change-Id: I0fea9714975d459fd3fa0b882736b68becdba539
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318328
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6312@{#185}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
aarongable pushed a commit that referenced this pull request Mar 25, 2024
Roll Chrome Mac PGO Profile
f927dba 
Roll Chrome Mac PGO profile from chrome-mac-6367-1711300579-eeefa7f46443825ce3bf76933de22810d6ce4d3d-3679d13af631f30bc865a3664688c46b8881d406.profdata to chrome-mac-6367-1711324243-9bd96a53717e4f2a3f87f8fb3f6e149fe7a86dba-6ac91b0d81050d473ed5734235b2f11ed934d4a2.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m124.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia7c6b755d9d917c30d11f10fd7c0ae28c3e14045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5390733
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6367@{#185}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 21, 2024
Roll Chrome Win32 PGO Profile
83bcfa9 
Roll Chrome Win32 PGO profile from chrome-win32-6422-1713675331-d8d715ea1f9278def684b7ca4493d1962f27edb0-f5b58a09480e8826154f56b6220a2824ef12f448.profdata to chrome-win32-6422-1713699177-f6724e0914c2140ce9a4dec98c909d16aacf3413-5ff55575eb9a2d22acb2574b296942977b16900a.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m125.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ifb45610416c76b18e4cb4409edd53878804f0055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5470443
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6422@{#185}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacoder101 dacoder101 dacoder101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@KUNDAN1334 @dacoder101