Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authors name #184

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KUNDAN1334
Copy link

CLOSED #183

aetota61 pushed a commit to monkbrowser/monk-browser that referenced this pull request Aug 2, 2023
Roll Chrome Mac PGO profile from chrome-mac-5790-1685509565-d4ab80691c992ed3856a6eaa5b18e78c0e070810.profdata to chrome-mac-5790-1685532515-55252dd20e89fba700cd3fe9ebedf5ef1dc50301.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m115.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia3b0aa4286ab85d31ccf4a930a68f72844cb5001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4577237
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5790@{chromium#184}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
l0hn pushed a commit to protectednet/hopium that referenced this pull request Aug 23, 2023
…ies.

IMPORTANT: This has one significant side effect on PrivateAggregationTimings! script_run_time and signals_fetch_time are recorded in InterestGroupAuction::OnScoreAdComplete(); prior to this change, a zero time is recorded for both of these when the script encounters an error, i.e. when SellerWorklet::V8State::PostScoreAdCallbackToUserThreadOnError was called; after this change, the actual script/signal-load times are recorded instead. This is because the same fields (scoring_latency and score_ad_dependency_latencies) are used for both PA Timings and the UKM metric.

Beyond that, the rest of this change is strictly the addition of new UKM metrics to the AdsInterestGroup.AuctionLatency.V2 event. In previous commits, reviewed as
https://chromium-review.googlesource.com/c/chromium/src/+/4359997 and
https://chromium-review.googlesource.com/c/chromium/src/+/4386873, we
added metrics for the latency of GenerateBid and its surrounding flow,
including metrics around delays caused by high-latency inputs to
GenerateBid. This commit adds the analogous metrics for ScoreAd and its
high-latency inputs.

As with those earlier commits, this adds several metrics:

1. ScoreAdFlowLatency reflects the latency of the entire ScoreAd flow,
   from InterestGroupAuction::ScoreBidIfReady to
   InterestGroupAuction::OnScoreAdComplete.

2. ScoreAdLatency reflects the latency of only the call to
   V8State::ScoreAd, a component of the flow reflected in (1).

3. ScoreAdCodeReadyLatency, ScoreAdDirectFromSellerSignalsLatency, and
   ScoreAdTrustedScoringSignalsLatency metrics reflect the latency and
   critical path latency (delay) of each of these dependencies that must
   be satisfied before V8State::ScoreAd can run.

(cherry picked from commit 9d5ce47)

Bug: 1424365
Change-Id: I1aaaa336991d818d142ba5e93ec9024d5ac053a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584089
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Orr Bernstein <orrb@google.com>
Reviewed-by: Sun Yueru <yrsun@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1161948}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4643818
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5845@{chromium#184}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
blueboxd referenced this pull request in blueboxd/chromium-legacy Sep 10, 2023
Updates the size of the kite icon and "Ask in a message" button to align with other interstitial pages on iOS.

(cherry picked from commit 94099da)

Bug: b/295145266, b/295144661,1471926
Change-Id: If7b7e7d3931de4f96fd2af2e806c67bb55a1d323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4765577
Reviewed-by: Liza Bipin <mlbipin@google.com>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1182135}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4775678
Commit-Queue: Liza Bipin <mlbipin@google.com>
Auto-Submit: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/branch-heads/5938@{#184}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
trflynn89 pushed a commit to RebelBrowser/rebel that referenced this pull request Oct 26, 2023
This CL introduces a new section in the password settings which only
shows to eligible users. This section allows users to bulk move local
passwords to their account. The CL has some empty protocol methods
which will be implemented in a follow-up CL.

https://drive.google.com/file/d/1L3lYMN1GWJrVHxQpMaJSyjPWPT502MZ1/view?usp=sharing&resourcekey=0-hLAMw0w-QpJlfCRFdYRCKg

(cherry picked from commit 360f904)

Bug: 1479545, b/296413085, b/296442506, b/296413093
Change-Id: Iab09f3d82cdf87d5aa6718709679b04df15f45ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4833440
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Nicolas MacBeth <nicolasmacbeth@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1193415}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850695
Cr-Commit-Position: refs/branch-heads/5993@{chromium#184}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
This reverts commit 735e0ce.

Reason for revert: crbug.com/1419770

Original change's description:
> Disable copy migration.
>
> lacros.{Migrate,MigrateBasic,MigrateExtensionState,BackwardMigrateBasic,
> BackwardMigratePolicy}
>
> Test: unit_tests, browser_tests, tast run $DUT\
> Bug: 1416750
> Change-Id: I1fcb02852d5a9a1f38c9db90efffd84c16e9717f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4270320
> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1108533}

Bug: 1416750
Change-Id: I4e8c34ec00754865a85f18081db05cb04743176d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296056
Owners-Override: Srinivas Sista <srinivassista@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Srinivas Sista <srinivassista@chromium.org>
Cr-Commit-Position: refs/branch-heads/5615@{chromium#184}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
Roll Chrome Win32 PGO profile from chrome-win32-6045-1696757941-65edb03d02bc3ac87df3936736bd7646ade1bc75.profdata to chrome-win32-6045-1696782300-e7b6948e8451e1315fb66c7f3972898f69115ec3.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m119.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie696622ce81a282689fc75e1e2ac76df0565e1bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4920223
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#184}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori pushed a commit to Pissandshittium/pissandshittium that referenced this pull request Dec 8, 2023
Roll Chrome Linux PGO profile from chrome-linux-6099-1699119607-86f116dbb3738cfa1edd86b15d6cbf895ecedcf3.profdata to chrome-linux-6099-1699132967-f9a5d5f1b7cf4053045431aa454e5a5d1e8007c3.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m120.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I69654da0dd734bddadecae27766b744559fe024a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006692
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{chromium#184}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 6, 2024
Roll Chrome Win32 PGO profile from chrome-win32-6167-1702178078-514c7ee6fa762bce9be9d0cfb92ccc5bd808e34e.profdata to chrome-win32-6167-1702199807-fe9c1bdcb6a188b04bfa41a854475e7f43613b93.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m121.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I02b73020d58bb4ad3e78f6bf173daa76229f0277
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5106327
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6167@{#184}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable pushed a commit that referenced this pull request Jan 27, 2024
Roll Chrome Mac PGO profile from chrome-mac-6261-1706326559-d5b3939abe1d510a9aba6c5facacf5d255d93a15.profdata to chrome-mac-6261-1706349784-9305d312eac0ae7b08b875b93e2f1a956198d6b5.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m122.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I84326ce9cbb8422c5913f135ee09388f115b624d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5242024
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6261@{#184}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
ecotopian pushed a commit to ecosia/chromium-android-browser that referenced this pull request Feb 12, 2024
Replace "floor" with "round" to correctly compute the number lines of
a wrapping string.

(cherry picked from commit 2e01675)

Bug: 1412263
Change-Id: Id9b46f0e1237184042670dce805dab3948b13163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4217491
Auto-Submit: Christian Xu <christianxu@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1100891}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4222016
Cr-Commit-Position: refs/branch-heads/5563@{chromium#184}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable pushed a commit that referenced this pull request Feb 27, 2024
Roll Chrome Linux PGO profile from chrome-linux-6312-1708969797-e81cb1e46b9316902e9936cf89620a51188721f3-8e1541a1b9b1db5dd43547a5d179be2debb4c04c.profdata to chrome-linux-6312-1708991890-096d714daf60a5900e742691710c37b040c7eacc-9313089519654579959a9cd96f613e71b9ba972c.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m123.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I8e23635512ed508d955d2167dbe029217cc29cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5325941
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6312@{#184}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
aarongable pushed a commit that referenced this pull request Mar 25, 2024
Roll Chrome Linux PGO profile from chrome-linux-6367-1711300579-b420db57e0fc7da28a192406a27d1143d2981705-3679d13af631f30bc865a3664688c46b8881d406.profdata to chrome-linux-6367-1711324243-ecc822f6e4eef70686ce347dc1bc02b406b72ab0-6ac91b0d81050d473ed5734235b2f11ed934d4a2.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m124.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ib1394640254e0591cbe95eaa80891bbba94f04c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5390845
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6367@{#184}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 21, 2024
Uploaded by https://ci.chromium.org/b/8750090409166969537

Change-Id: Ib9dfb5cc55f20a3d383161d94838bc4eec7d15dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469899
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6422@{#184}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant