A test change #179
Open
A test change #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msizanoen1
pushed a commit
to qtmlabs/chromium
that referenced
this pull request
Jun 29, 2023
…arted App Close Refresh experiment showed huge increase in CUI#1 AppFlows, specifically launch start events. The reason for this is that the DiscoverFeedService is often not started (e.g., when the current tab on a cold start is non-NTP). If the service was not previously started, ACR causes it to be instantiated, thereby triggering a Discover launch event when the app is backgrounding. Future work will need to change the triggering of launch events. But this CL is enough to stop the ACR LE from artificially causing AppFlow count increases. (cherry picked from commit 45f064d) Change-Id: I699989c5b682fe95040d7933b3c7525c646354fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4633902 Commit-Queue: edchin <edchin@google.com> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1162589} Bug: 1458483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4654196 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: edchin <edchin@google.com> Cr-Commit-Position: refs/branch-heads/5845@{chromium#179} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
aetota61
pushed a commit
to monkbrowser/monk-browser
that referenced
this pull request
Aug 2, 2023
Roll Chrome Win32 PGO profile from chrome-win32-5790-1685468579-1406bea6c1ad43d654ef2c5cf1fadf013a732d9e.profdata to chrome-win32-5790-1685509565-92550c3c8509355b94042ac5b4f6829f6e65cb43.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m115.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idddb24660f3d8dfcd453674c90701dcc98a8862b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576607 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790@{chromium#179} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Sep 10, 2023
Show the "new" IPH badge only 24h after install. (cherry picked from commit 016ba17) Bug: 1472216 Change-Id: I4bdf2e40a404fa1dc82eda056b87eb4731639260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4772956 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Christian Xu <christianxu@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1182963} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4778043 Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/branch-heads/5938@{#179} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
trflynn89
pushed a commit
to RebelBrowser/rebel
that referenced
this pull request
Oct 26, 2023
Currently, the generation of a name field depends on the test type, whether or not the test had a variant applied or whether the actual test to be run has been overridden. This requires knowledge of the runtime behavior to figure out the name of a test when looking at the generated output. This CL changes it so that all tests have a name field generated. With all tests having a name field generated, much of the code can be simplified because it can assume that the name field is set and just use that. In particular, there is no need for any test-type-specific sorting. The name field will have the variant identifier appended when a test is expanded with a variant, so code that is providing a default value for the test/isolate will still use the test name set in test_suites.pyl. (cherry picked from commit ffe83c4) Bug: 1475835 Change-Id: Iada7adfdf94e6747d7dec1a765d4e15fe3cfbe7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4844437 Auto-Submit: Garrett Beaty <gbeaty@google.com> Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1194259} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4855895 Commit-Queue: Garrett Beaty <gbeaty@google.com> Cr-Commit-Position: refs/branch-heads/5993@{chromium#179} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Records a metric in a sparse histogram every time a key is repeated using the builtin ChromeOS auto repeat feature. Records a hash of the KeyboardCode + 5 bits of modifiers to track Meta/Ctrl/Alt/Shift/Caps. (cherry picked from commit 4865f92) Change-Id: Ib836c25f2af5882d0c2b2a4f79d1258ff3b0153e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4297977 Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: David Padlipsky <dpad@google.com> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1111403} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4302786 Cr-Commit-Position: refs/branch-heads/5615@{chromium#179} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Change-Id: I82badd9a9705f8d8a6a73147c749f71b4d92e0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4920141 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#179} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori
pushed a commit
to Pissandshittium/pissandshittium
that referenced
this pull request
Dec 8, 2023
Change-Id: Id90b612e1cf9128f57ac6e5d29d17ed2fe874035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006632 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{chromium#179} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
Roll Chrome Win64 PGO profile from chrome-win64-6167-1702156039-eb5f8d1ad7fcda6910c9b18b4200613971a14bc8.profdata to chrome-win64-6167-1702178078-cc0f230be8b45192735a7ae77dc5d1b540808b89.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I29d7448b3ea377a539cb9411d045f0e34e39958a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5108418 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#179} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 27, 2024
Roll Chrome Linux PGO profile from chrome-linux-6261-1706326559-307e9256be53de7e8890c7b32c2171f025a42bae.profdata to chrome-linux-6261-1706349784-98e18755d38167a9535c6ffaecfa597c63e9b064.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m122.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I87b0cbaf84485939ca1ff96509329274b95c96af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5242250 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#179} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
ecotopian
pushed a commit
to ecosia/chromium-android-browser
that referenced
this pull request
Feb 12, 2024
(cherry picked from commit 59090d0) Bug: 1412745 Change-Id: I178e5f3a1a48c04a9c1f491acb872629ab3d2ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219018 Auto-Submit: Rubin Deliallisi <rubindl@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1101040} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4223378 Commit-Queue: Rubin Deliallisi <rubindl@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/branch-heads/5563@{chromium#179} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable
pushed a commit
that referenced
this pull request
Feb 27, 2024
crrev.com/c/5280536 had a subtle bug where the internal ACResult's session data was being swapped with the published ACResult in Sync and LastAsync autocomplete passes. This resulted in that data to be lost from the internal ACResult and not be set on the ACMatches in ACController::UpdateSearchboxStats(). The unit tests also failed to detect that. This CL fixes that bug, renames ACResult::Swap() to ACResult::SwapMatchesWith(), reorganizes the code and adjusts the comments for clarity, and improves the unit tests. crrev.com/c/5286774 also had a subtle bug where zero_prefix_enabled was being set to true in ACController::UpdateSearchboxStats() which is reached when zero-prefix suggestions are shown, not zero-prefix suggestions could've been shown as it is expected by this metric to report. This CL also fixes that by setting zero_prefix_enabled earlier in ACController::Start(). This CL also enables the feature by default to facilitate merging this change (1 CL to merge instead of 2) to m123. (cherry picked from commit 338b53b) Bug: 1307142 Change-Id: I0d53f429ff8b39aa5b4257bbf4219e729d6822ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5309407 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1263124} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321215 Cr-Commit-Position: refs/branch-heads/6312@{#179} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
aarongable
pushed a commit
that referenced
this pull request
Mar 24, 2024
Roll Chrome Win64 PGO profile from chrome-win64-6367-1711274584-6853a7d0cabab56c62b2b370db19474ce8fec181-ff5e8991c67c9e18ee112963d786c2c0c4525fba.profdata to chrome-win64-6367-1711300579-f9e5c63c879bf4d218d84d8615230425e9dbd7d0-3679d13af631f30bc865a3664688c46b8881d406.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m124.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0f203807a12f3d1aca29e019cabc2c8415002054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5390636 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#179} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
Apr 21, 2024
Roll Chrome Win32 PGO profile from chrome-win32-6422-1713652726-f6b7f854f1488cfe25df5fd648fabcd140f8d034-2fdcfa53d4f6c175cb0296fa40a6058659e40db8.profdata to chrome-win32-6422-1713675331-d8d715ea1f9278def684b7ca4493d1962f27edb0-f5b58a09480e8826154f56b6220a2824ef12f448.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m125.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I42679f26d11205a7d88bfb49db9ea54042bb9710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5470264 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#179} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.