New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test pr #178
Open
hanwen
wants to merge
1
commit into
chromium:main
Choose a base branch
from
hanwen:test-pr
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Test pr #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msizanoen1
pushed a commit
to qtmlabs/chromium
that referenced
this pull request
Jun 29, 2023
This will allow us to directly analyze the degree to which config promises are being used, and to correlate these to other metrics, e.g. e2e latency, to better understand the scale of impact of using config promises. (cherry picked from commit ac131f0) Bug: 1424365 Change-Id: I8ffdd7e27e3bda97feccb84b7cdb857c627be679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601771 Reviewed-by: Sun Yueru <yrsun@chromium.org> Reviewed-by: Caleb Raitto <caraitto@chromium.org> Commit-Queue: Orr Bernstein <orrb@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1160889} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4644329 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/branch-heads/5845@{chromium#178} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
aetota61
pushed a commit
to monkbrowser/monk-browser
that referenced
this pull request
Aug 2, 2023
Roll Chrome Win64 PGO profile from chrome-win64-5790-1685490441-bcaa94f9269f411eb8f88ccc009909ddc557739d.profdata to chrome-win64-5790-1685509565-a0f53d532eb5285d741d6ebd367b802bea69c54f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m115.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I281602d4d907813e78124c3e0d879ea43d102e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576036 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790@{chromium#178} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Sep 10, 2023
Roll Chrome Win32 PGO profile from chrome-win32-5938-1692121783-6da753c996836c8eba98a499a3956b89a39abf25.profdata to chrome-win32-5938-1692140361-34b6d8a858285f7beedd945292dc410fe63b5589.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m117.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3ed84119cbf5296d21114e5839a6d2a9966a0156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4782210 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938@{#178} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
trflynn89
pushed a commit
to RebelBrowser/rebel
that referenced
this pull request
Oct 26, 2023
Noise cancellation might not appear on the panel if the device get into a state where it unregister the effect but never register back. This CL add the extra necessary observers to avoid this from happening. (cherry picked from commit 94c326d) Bug: b:299474205 Change-Id: Iab499a120f4402e1e911587249c06d4555c097c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4851677 Commit-Queue: Jiaming Cheng <jiamingc@chromium.org> Reviewed-by: Jiaming Cheng <jiamingc@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by: Li-Yu Yu <aaronyu@google.com> Auto-Submit: Andre Le <leandre@chromium.org> Commit-Queue: Li-Yu Yu <aaronyu@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1194277} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4853975 Cr-Commit-Position: refs/branch-heads/5993@{chromium#178} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Rename STARTUP_FEATURE_SET_DIRECTORY_BASE_PATH:DEV to STARTUP_FEATURE_SET_DIRECTORY_BASE_PATH (cherry picked from commit 637cdf9) Bug: 1420749, 1355297 Change-Id: Iea2c4fc9cf0c586c7fcc1b6b3e52f2e895640b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4300277 Commit-Queue: Abhijith Nair <abhijithnair@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1111866} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4306703 Auto-Submit: Abhijith Nair <abhijithnair@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/branch-heads/5615@{chromium#178} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Roll Chrome Mac PGO profile from chrome-mac-6045-1696736910-5de265e5cb4dae98b8a3a4e52d3e9ad77357f661.profdata to chrome-mac-6045-1696757941-cef82cc392a270fbb83ae41198807c03b4878399.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m119.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3188cf1fd7eec6d8792d8db93bf240c054fa3764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4920220 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#178} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori
pushed a commit
to Pissandshittium/pissandshittium
that referenced
this pull request
Dec 8, 2023
Roll Chrome Win64 PGO profile from chrome-win64-6099-1699095171-e2c2a2fcfbd54c968cd5f039aa0a6af355547235.profdata to chrome-win64-6099-1699119607-b0e055f2f08120f7c9d0b36b66bf0964294f12aa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m120.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6dcffdf835785d3d2374378100628655533f3628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006517 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{chromium#178} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
Roll Chrome Mac PGO profile from chrome-mac-6167-1702156039-14a329d59e6e7ea4f441d12421bb0cd9fd626504.profdata to chrome-mac-6167-1702178078-e4b31c38bbbe6c39174a051d8f119df093e5fd8d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7a86fa89ba194990fd3731e8a1f11efdbe13e373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5108419 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#178} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 27, 2024
Roll Chrome Win64 PGO profile from chrome-win64-6261-1706311063-5efeb3bbd0f4a1aaf0eb76551deed8effd96a5b1.profdata to chrome-win64-6261-1706326559-b11d9e57d708c0af97f92062b570094b2b2e750a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m122.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie181649591361c6935fa6354099bd4695993c863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5242498 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#178} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
ecotopian
pushed a commit
to ecosia/chromium-android-browser
that referenced
this pull request
Feb 12, 2024
Updates the restricted check on startup to also disable M1 APIs, and reset any consent information. As with previous launches, while API functionality is disabled immediately on restriction, prefs are only altered on startup. This is because there is no observer behavior for restriction. (cherry picked from commit 621857a) Bug: 1411679 Change-Id: If06f685eafa226dbf80b93ea82c9e6feb1ba994a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4209081 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by: Olesia Marukhno <olesiamarukhno@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1099794} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4223678 Auto-Submit: Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/branch-heads/5563@{chromium#178} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable
pushed a commit
that referenced
this pull request
Feb 27, 2024
Quick fix to clear the double cursor issue in the bug. Separately, we need to reevaluate how this handles focus. The bug occurs because we're inserting text after the control has been blurred once. So, we don't update the cursor again (but need to when focus is forcibly moved by the caller). (cherry picked from commit b11a071) Bug: b:324473858 Change-Id: Ifb9876b2dc48b94db1a17371f5a5398fd81e3f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5304326 Reviewed-by: Xiaodan Zhu <zxdan@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Auto-Submit: Sean Kau <skau@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1263052} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324854 Cr-Commit-Position: refs/branch-heads/6312@{#178} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
aarongable
pushed a commit
that referenced
this pull request
Mar 24, 2024
Roll Chrome Mac PGO profile from chrome-mac-6367-1711274584-7393c189e0562dd0a064341cd6896d27bc82f927-ff5e8991c67c9e18ee112963d786c2c0c4525fba.profdata to chrome-mac-6367-1711300579-eeefa7f46443825ce3bf76933de22810d6ce4d3d-3679d13af631f30bc865a3664688c46b8881d406.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m124.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4805bc9cc783f808424fa1e5a1bc92923b385e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5390648 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#178} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
Apr 21, 2024
Roll Chrome Win64 PGO profile from chrome-win64-6422-1713652726-0ebb1e83ff87450f7ccb048de7f32d30ec77a0f1-2fdcfa53d4f6c175cb0296fa40a6058659e40db8.profdata to chrome-win64-6422-1713675331-491fa2cc1f1a0a153e91810cf9c05219c39b04cb-f5b58a09480e8826154f56b6220a2824ef12f448.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m125.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I31a42e2e9c10f0165e197ae62143bda9306066e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469553 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#178} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.