Add semicolons to styles that do not have them #173

OscarNOW · 2023-06-07T20:16:47Z

In the file /third_party/blink/renderer/core/html/resources/html.css some styles do not have semicolons. I propose to add semicolons to all styles in that file to make it consistent.

Add semicolons to styles that do not have them in /third_party/blink/renderer/core/html/resources/html.css

google-cla · 2023-06-07T20:16:50Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

…enabled This CL adds logics to stop showing stand-alone ChromeCart module if ChromeCart+Quest feature is enabled. This CL also adds an feature variation to allow showing both ChromeCart and ChromeCart+Quest at the same time, and right now this option should only be used for testing purpose. Please note that for the Quest+Cart experiment, we cannot achieve the same as what we want in this CL by disabling the existing ChromeCart feature, because ChromeCart feature also controls other things like renderer side detection which is needed in Quest+Cart, so we need to keep the existing ChromeCart flag enabled. (cherry picked from commit 9d4bff0) Bug: 1431951 Change-Id: I46d3eb3a4cc974fbdead0ee7ff46691c83ec4e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4471915 Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1135917} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4499167 Cr-Commit-Position: refs/branch-heads/5735@{chromium#173} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}

git cherry-pick -x 7441976 e548b4b bc1bf4d Bug: 1458676 Change-Id: I1da7ce73a8de8b1e15beb4aa242504826970b7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4652891 Commit-Queue: Huiting Yu <huitingyu@google.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/5845@{chromium#173} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}

This plumbs through a different icon for the enterprise vs. parental management cases. See background in the linked bug, and screenshots in b/281641773#comment10. (cherry picked from commit 8739e29) Bug: b/281641773, 1449228 Change-Id: Id0b21997e49aaca18d4d407aaf103db5242a4326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4556407 Reviewed-by: Alex Ilin <alexilin@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: James Lee <ljjlee@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1149211} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571331 Commit-Queue: James Lee <ljjlee@google.com> Cr-Commit-Position: refs/branch-heads/5790@{chromium#173} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}

Commits rolled: https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/ab66c2b66e1d..857a7d6eea46 Generated by: go/bbid/8770213555408614417 Change-Id: I49d87d9ec87137b96d46b8835594e2b5866fa5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4854904 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5993@{chromium#173} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}

When the flag is enabled, the new layout with the left-aligned hint label and magnifying glass icon is used. Otherwise, uses the old centered hint label alignment. Also, adjusts the color of the microphone icon in the omnibox. (cherry picked from commit ac58fea) Bug: 1418046 Change-Id: I117750a258fc62ebc7248e1902c2ae48157ceaa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4284837 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Jason Hu <hujasonx@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1111134} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4304574 Cr-Commit-Position: refs/branch-heads/5615@{chromium#173} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}

Uploaded by https://ci.chromium.org/b/8767847473324828177 Change-Id: I4440eed29292cbb5df99fd625a2c5252868b752e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4920586 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#173} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}

…120.0.6099.9-r1 to 120-6085.0-1698659522-benchmark-120.0.6099.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I63ff435da27ce029532cae4565b3c513d8194f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5005615 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{chromium#173} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}

This cl only affect Lacros or Skylab on-device config builders like lacros-amd64-generic-chrome-skylab or "ChromeOS FYI Release Skylab (kevin)". This cl will certainly NOT affect linux-lacros builders (linux-lacros-tester-rel, linux-lacros-rel, etc) or any other platforms. This CL will update cros image version for skylab tests. CROS_BOARD_DEV, CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org. R=rubber-stamper@appspot.gserviceaccount.com Requires-Testing: True Change-Id: I674d537058378cdc064d415cfed4e51517658924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5104894 Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#173} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}

This CL updates the ash version ['123.0.6267.0'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I2cf93301e63c390d743aa72af391447436e4140c Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237782 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#173} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}

This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file go/crostc-bug. Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie5383eb5828245afd4a1bf21595e65257a6eacac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4223275 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{chromium#173} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}

There are reports of renderer kills on Android WebView due to new CanCommitURL restrictions added in r1260537. Disable the new checks on Android WebView until they are diagnosed and fixed. (cherry picked from commit 12373b8) Bug: 326250356, 324934416 Low-Coverage-Reason: OTHER Repro steps unknown. Change-Id: I5449875c0cf06f93f69d38f2a4c9cc41e7036d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314892 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1263648} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5319631 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Charlie Reis <creis@chromium.org> Commit-Queue: Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/branch-heads/6312@{#173} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}

Roll Chrome Linux PGO profile from chrome-linux-main-1691517382-0d9ed94f312f6fe3cd29ca09a9f0d2cc0158a4d5.profdata to chrome-linux-5938-1692121783-b044b2dfc0c293353827410dacc3b699ffa63faf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m117.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ief300b832bf633dfb33cd12daf51467677cfea13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4782046 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938@{chromium#173} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

Roll Chrome Mac PGO profile from chrome-mac-6367-1711250628-c65b4899a9115d5556682c34d817887c11ebf739-1a14b7ce485b2803db7225fc525f89e90de9c261.profdata to chrome-mac-6367-1711274584-7393c189e0562dd0a064341cd6896d27bc82f927-ff5e8991c67c9e18ee112963d786c2c0c4525fba.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m124.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3c75c463b20e2657631b5353ac377dbcec3306b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5390506 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#173} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}

This CL updates the ash version ['126.0.6430.0'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: Ie5ce1f844ace7a6d42052ed4fe1c486681d036d1 Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464224 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#173} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}

Add semicolons to styles that do not have them

823c204

Add semicolons to styles that do not have them in /third_party/blink/renderer/core/html/resources/html.css

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add semicolons to styles that do not have them #173

Add semicolons to styles that do not have them #173

OscarNOW commented Jun 7, 2023

google-cla bot commented Jun 7, 2023

Add semicolons to styles that do not have them #173

Are you sure you want to change the base?

Add semicolons to styles that do not have them #173

Conversation

OscarNOW commented Jun 7, 2023

google-cla bot commented Jun 7, 2023