New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Release #170
Open
darkalexis1990
wants to merge
1,191
commits into
chromium:main
Choose a base branch
from
win32ss:main
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Android Release #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aizaz-dev
pushed a commit
to SoftwarePrince/Egon-Browser
that referenced
this pull request
May 19, 2023
language The initial partial translation uses "Detected Language" as the source by default, which can be a much longer string than the actual source language. The text label for translated text needs to be resized after receiving the actual source language string to accommodate this difference, otherwise the bubble is shown artificially wide. Note that the width of the loading view will still be affected by this issue, as at that point we don't know the source language yet. (cherry picked from commit f10154b) Bug: 1384670 Change-Id: I1e982784c7bc117bf778000d0c523a7965f5e42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4026299 Reviewed-by: Basia Zimirska <basiaz@google.com> Commit-Queue: Anthony Cui <cuianthony@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1073142} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4044109 Commit-Queue: Basia Zimirska <basiaz@google.com> Auto-Submit: Anthony Cui <cuianthony@chromium.org> Cr-Commit-Position: refs/branch-heads/5414@{chromium#170} Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
May 27, 2023
If a device is mis-configured and a 32-bit Chrome is loaded onto a device that doesn't support it, if it's a user-visible flow, notify them to pursue updates. This shouldn't happen in the field in practice, but adding a message for users because Chrome is unusable if it does happen. (cherry picked from commit 465cdf7) Bug: 1432698 Change-Id: I05a2d6e8b257c6a49ec9e0e498917ae2a456540c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4476366 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1137313} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4499169 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/branch-heads/5735@{#170} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1
pushed a commit
to qtmlabs/chromium
that referenced
this pull request
Jun 29, 2023
When BrowsingDataRemover is called with an empty 'kDelete' filter, it should not delete any data. Cookie deletion had a bug that caused it to delete all cookies. Ensure that this is fixed and covered by tests. (cherry picked from commit eca439f) Bug: 1457600 Change-Id: I7339e154e364c9af8c109d7d7dd259ce2893c675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4645409 Reviewed-by: Dylan Cutler <dylancutler@google.com> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1162428} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4650752 Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/branch-heads/5845@{chromium#170} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
aetota61
pushed a commit
to monkbrowser/monk-browser
that referenced
this pull request
Aug 2, 2023
The problem is that the AppLaunchSplashScreenHandler keeps a pointer to the NetworkUiController after CleanUp is called and therefore potentially after the NetworkUiController is deleted. Additionally, the delayed deletion of NetworkUiController and other components keeps dangling pointers to KioskLaunchController around (cherry picked from commit 9ffd5e7) Bug: b:283740287 Test: KioskLaunchControllerTest Change-Id: Id66fe3e60ad67231039bd4080b5837f2581a5f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4557825 Reviewed-by: Jeroen Dhollander <jeroendh@google.com> Commit-Queue: Ben Franz <bfranz@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1148463} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574365 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790@{chromium#170} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
trflynn89
pushed a commit
to RebelBrowser/rebel
that referenced
this pull request
Oct 26, 2023
In ExternalBeginFrameSourceMac::OnDisplayLinkCallback(), Replace |frame_time|, which is passed down from the CVDisplayLink thread, with Now() in the Viz thread. This makes the comparison more accurate. DelayBasedBeginFrameSourceMac::OnTimerTick() uses Now() for the current frame time. Bug: 1404797 (cherry picked from commit b86e693) Change-Id: I0e02b20b79c4376b936913849bb1f81a6be306bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4847137 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by: ccameron chromium <ccameron@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1194165} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4857098 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Maggie Chen <magchen@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5993@{chromium#170} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
… are clicked This change enables triggering the virtual card unmasking flow when virtual cards are clicked. A boolean `isVirtual` is added as an argument to the on-card-select callback function to let the native delegate know if the selected card was a real or a virtual card, and trigger the corresponding flow. Design doc for the feature: go/ttf-virtual-cards Implementation doc: https://docs.google.com/document/d/1ykpW3F8h_qFmZS_kWT9sGUZaFV5eJ09iG6O8FUcMdeo (cherry picked from commit 69a9e65) Bug: 1415020, 1420640 Change-Id: I17a3b70c9c26a0402f9e774c6762bd4809a22875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4261646 Commit-Queue: Vishwas Uppoor <vishwasuppoor@google.com> Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by: Christoph Schwering <schwering@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1111680} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4303135 Cr-Commit-Position: refs/branch-heads/5615@{chromium#170} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Roll Chrome Mac PGO profile from chrome-mac-6045-1696715571-eb90c1da22548d390acdcd6d7554c065c9d289da.profdata to chrome-mac-6045-1696736910-5de265e5cb4dae98b8a3a4e52d3e9ad77357f661.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m119.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7a392af812eccae8f65842580103bb35b4505d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4920894 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#170} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori
pushed a commit
to Pissandshittium/pissandshittium
that referenced
this pull request
Dec 8, 2023
Roll Chrome Linux PGO profile from chrome-linux-6099-1699070444-7c44bd376031aedc6d4a1b4998c7a31558473f43.profdata to chrome-linux-6099-1699095171-3799fc63756a6ff6e59074f5f83e01d5048f3ed6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m120.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I64ca91732d3daaeb8b56fd853e3793c9481587b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006095 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{chromium#170} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
Roll Chrome Win64 PGO profile from chrome-win64-6167-1702115692-8f6320f1e99bcba34353af44ba4e26c01a50fc1f.profdata to chrome-win64-6167-1702141771-55baffeaafc705ddb17fa950d786ebfdbb51f1d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I20b33339098be2d49c6d2f6a785af706a92d6233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5108158 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#170} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 27, 2024
Change-Id: Idd0cca5d5c4df9853184fbc1337a2f25cdc41de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241958 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#170} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
ecotopian
pushed a commit
to ecosia/chromium-android-browser
that referenced
this pull request
Feb 12, 2024
…rk-111.0.5563.12-r1 to 111-5550.0-1675083099-benchmark-111.0.5563.13-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ife29ef38bc1f5b87a744718a568639e14d12ad00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4222502 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{chromium#170} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
Change-Id: Id89853b6525a37170f40b2b435499bcc1c5ec52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318304 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#942} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
Automatic update for 2024-02-24 UTC Change-Id: Ic928d5807d8740cd5d452323ff4d2850ad4ae7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5322898 Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Cr-Commit-Position: refs/branch-heads/6261@{#943} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
Change-Id: I02b2111746f5823a5c2e666195376f7e7595599e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5322295 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#944} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
Change-Id: Id5086d73c95103fc1fbd9059888d606d8e788584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5322128 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#945} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
Uploaded by https://ci.chromium.org/b/8755161964656107393 Change-Id: Ieb0a6f9773cf738c69785737c667968043b59f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5322197 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#946} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
Change-Id: I61571c2a7dccea425881b3950ffa56bd9a0397f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5319470 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#947} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
ShellSurface will attempt to update the widget's screen position after a display configuration change. This CL ensures the `widget_` exists before attempting the update, guarding against potential UAF crashes. (cherry picked from commit 1335bc6) Bug: 322388171 Change-Id: Ic1d6bf6aa86ad2310448dfd1cd1c003ae727686f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5284355 Auto-Submit: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1259334} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5320252 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/6261@{#948} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
DriveFS expects this struct to be non-null, so for now, always give it a value. The value itself doesn't matter as it is not used on error. (cherry picked from commit 7bc3124) Bug: b:325351184 Change-Id: I9cfbfd15029ba73185a1b5f47717a261e7fa6302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5316796 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1263803} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5322761 Auto-Submit: Austin Tankiang <austinct@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#949} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
Change-Id: I6d654ef71d504e84e0099628a3e2438f66123765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5323184 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#950} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
Commits rolled: https://webrtc.googlesource.com/src.git/+log/be2786cd2383..6b419a0536b1 Generated by: go/bbid/8755021577473063265 Change-Id: If2964a6698e929f177728e62c9bd0f17153688b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5323447 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#951} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
Change-Id: I0529c485868b709aa1ed2856b83e7775def7bcb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5322864 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/branch-heads/6261@{#952} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
Uploaded by https://ci.chromium.org/b/8755071535515728289 Change-Id: I5ac059342204793c6da47e676116f4718b67acdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324322 Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#953} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
Commits rolled: https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7ef43bca02ec..6088a4554c16 Generated by: go/bbid/8755014027242006641 Change-Id: I8fbf40d112d6cbc57194ef4df71914e466ec737a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324282 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#954} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
* Update BUILD.gn * Update internal_plugin_renderer_helpers.cc * Typo fix * Clang lint * revert pdf change as per win32ss guidance * Fix omnibox radius and border flag * Update layout_provider.cc * /O2 * Always fully optimize in release builds. * Update about_flags.cc * Only apply /O2 if this isn't a debug build * Fix error I made Self explanatory. --------- Co-authored-by: Shane Fournier <93808768+win32ss@users.noreply.github.com>
…led-supermium mode
… installer. The switch will be used to run the browser silently and briefly at the end of installation and apply ungoogled-supermium to the local state. A more robust solution is in the works.
This reverts commit d7c7af7.
This reverts commit 141aab8.
This reverts commit ddbedae.
This reverts commit 538d1c9.
This reverts commit da298f9.
This reverts commit ea6b881.
This reverts commit 0c3fce1.
This reverts commit 9870be7.
This reverts commit 20ba924.
This reverts commit 43d79d0.
This reverts commit 5d61d18.
This reverts commit 7db4ce9.
This reverts commit f3f69ef.
This reverts commit 9517b56.
This reverts commit f39d88f.
…t to true" and fixing outstanding FTP issues This reverts commit 83f8172.
…c-omnibox metrics being applied elsewhere including to menus. Also testing a method for further customization of UI metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Possible Android release in the future?