Performance improvements #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efrat-safanov
commented
Dec 4, 2012
efrat-safanov
commented
- improve Redis storage engine performance
- added expiration to Redis page storage
- added stop crawl functionality
- improved RAM usage (page queue got filled up too quickly)
added 13 commits
November 15, 2012 18:41
add some memory limitation on queues
improve redis storage performance
…ng all pages in queue
changeing stop_crawl behaviour to stop new links, but finish processing ...
deadlock fix - pages queue could be refilled by waiting threads
|
I think the major issue is bcos of the class variable @page storing all the pages. If you remove that there is no mem leak |
|
FYI this did help a lot with memory issues. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.