Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Update install script URL #555

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

pauby
Copy link
Member

@pauby pauby commented Dec 21, 2023

Description Of Changes

This is a minor change to update the URL used by the install script. We use ch0.co domain, so this is just a cosmetic change.

Motivation and Context

Being consistent with our shortlinks.

Testing

Clicked the link and it goes to the same URL as the old link.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

@pauby
Copy link
Member Author

pauby commented Dec 21, 2023

@mwallner I'm not sure if this URL is part of the work you are doing under #551?

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Dec 21, 2023

@pauby no objections from me for this to go in. If you can update this branch on the head of develop, we can get this merged.

@pauby
Copy link
Member Author

pauby commented Dec 21, 2023

@gep13 that has been done now.

@mwallner
Copy link
Member

@mwallner I'm not sure if this URL is part of the work you are doing under #551?

not really, upgrading the buildscript doesn't influence what's packed/bundled with Boxstarter at all, but this needed to be done anyway 🤗

@mwallner mwallner merged commit 8594a52 into chocolatey:develop Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants