(#27)(#39)(#46)(#45) Rework and update the repository #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eferences Also removes template/example packages from ketarin
TheCakeIsNaOH
force-pushed
the
fixups
branch
2 times, most recently
from
c4b07e5
to
2108e1f
Compare
TheCakeIsNaOH
changed the title
pauby
reviewed
Jan 12, 2024
There was a problem hiding this comment.
These are minor corrections.
This all looks good to me. I can't comments on the appveyor scripts / yml file without running it. But at a glance it looks fine.
Thats for doing all this work @TheCakeIsNaOH
Co-Authored-By: Miodrag Milić <miodrag.milic@gmail.com>
…ow a template repository
There was a problem hiding this comment.
The changes LGTM, and it looks like most of the changes are similar to what is being used in https://github.com/chocolatey-community/chocolatey-packages. Before I put a final approval from me, though, I would like to test out the image used in the AppVeyor script in the above mentioned repository.
I'll schedule some time next week to make those changes in that repository and come back to this PR afterward.
tnc1997
added a commit
to tnc1997/chocolatey-packages
that referenced
this pull request
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major rework and update of the files in the repository. This removes ketarin references, switches au to chocolatey-au, and updates the scripts based on updates to the the majkinetor and chocolatey-community/chocolatey-packages repositories.
Fixes #27
Fixes #39
Fixes #45
Fixes #46