Fix issue with linking dependency of -lstdc++fs when using flatpak #3966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkpaine
approved these changes
May 7, 2024
|
LGTM. Context: this was indeed a legacy leftover from the time around 2019 when compilers did not universally have the latest Thanks for removing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to build Surelog inside a flatpak, it fails due to a linking issue with
-lstdc++fs.See opened topic here: flathub/flathub#5221
It seems to be an old legacy linking practice that should be removed or it should be able to properly detect old versions of Ubuntu that requires it.