Update Wire.cpp #483
Open
Update Wire.cpp #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix, when slave NACK received, next transmission would freeze system due to transmit buffer not empty from previous transmission.
|
I think I have personally experienced this. What device are you taking to and what board are you using? Fubarino Mini 2.0 and PONTECH Quick 240's are easy boards for me to test with. Without digging deeper the change look innocuous none the less. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix, when slave NACK received, next transmission would freeze system due to transmit buffer not empty from previous transmission.
This can happen when a slave disappears from the bus. In my example the SCL would stay low and my clicker 2 board would freeze completely due to while loop in beginTransmission that blocks until transmit buffer is empty.
