Tests with sqlite in-memory #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff renders database as used in automated test suite independent of configured production database connection - you can freely run tests without affecting your production database. I tested the above by turning off my local MySQL server - test suite did not complain and ran exactly as it had before I turned my local server off. I am aiming to enable more aggressive and comprehensive automated testing, at unit, integration and functional levels. For example, assuming Laravel's functionality is up to it, it now should be possible to write a functional test that creates a new user (possibly with some problems) and verify that the new user gets created cleanly or not at all..
CyberiaResurrection
changed the title
|
@CyberiaResurrection You have changed the default DB to sqlite. Is it working for you with left and inner joins with tables ? |
|
I haven't changed the default for production - that remains at whatever has already been set (currently mysql), only for running tests. Give me a bit and I'll push up a test case. |
|
As promised, a test case illustrating how to do a basic join using Laravel's database abstraction layer. |
|
Sorry, that was a rather long-winded way of saying yes, they work. I was also trying to give you a way to independently check that joins work. |
|
Is there anything else you want me to provide? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No direct bug fixes here, but laying the ground work to easily write (and use) more comprehensive and aggressive tests. As a nice side effect, migrations and seeds get a workout with each test run.
The immediate use case I had in mind when making these changes was tackling #95, since that looks like it might need a functional test to fully characterise underlying issue - I have no doubt blank first and/or last name is part of issue, but it might not be all of it.