Add test coverage for HeaderElement and AcceptElement
#2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Apr 23, 2024
webknjaz
reviewed
Apr 23, 2024
7 tasks
This is in preparation for issue cherrypy#2014 Establishing tests to validate these objects so we can pull in the deprecated cgi.parse_header code
|
@webknjaz I pushed up some updates to address comments last week. Do I need to do anything else for this to go in? |
|
Thanks for reminding! I'm going to take another look at this now as I'm on the PyCon US Sprints. |
webknjaz
reviewed
May 21, 2024
cherrypy/test/test_httputil.py
Outdated
| def test_accept_element_raises_400(header_content, media_type, qvalue): | ||
| """ Test that headers passed to AcceptElement from httputils | ||
| raise an expected HTTPError """ | ||
| httputil.AcceptElement.from_str(header_content) |
There was a problem hiding this comment.
Given the other comment I made, I'm surprised that this doesn't fail in the CI — it seems like you expect that it would.
webknjaz
reviewed
May 21, 2024
webknjaz
reviewed
May 21, 2024
webknjaz
reviewed
May 21, 2024
webknjaz
reviewed
May 21, 2024
webknjaz
reviewed
May 21, 2024
webknjaz
reviewed
May 21, 2024
webknjaz
reviewed
May 21, 2024
webknjaz
reviewed
May 21, 2024
webknjaz
reviewed
May 21, 2024
webknjaz
reviewed
May 21, 2024
webknjaz
reviewed
May 21, 2024
webknjaz
reviewed
May 21, 2024
|
|
||
| The expected exception is :exc:`~cherrypy.HTTPError`. | ||
| """ | ||
| with pytest.raises( |
There was a problem hiding this comment.
@radez so as I implemented this, the problem with the expectation in the test got evident. Could you see if you can identify what inputs would actually lead to the validation error expected here...
webknjaz
changed the title
HeaderElement and AcceptElement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for issue #2014
Establishing tests to validate these objects so we can pull in the deprecated cgi.parse_header code
What kind of change does this PR introduce?