Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lock files when clean up session files #1957

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

jiangwen365
Copy link

What kind of change does this PR introduce?

  • bug fix
  • feature
  • docs update
  • tests/coverage improvement
  • refactoring
  • other

What is the related issue number (starting with #)
#1855

What is the current behavior? (You can also link to an open issue here)
Lock files are not removed, even when expired session files are removed by the clean-up thread.

What is the new behavior (if this is a feature change)?
Remove the lock files that have no session files at the end of session clean-up.

Other Information:
It might be a dirty fix just to save admins' efforts to delete the huge amount of obsolete locking files outside of CherryPy.

Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant