Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added absolute index flag to staticdir #1953

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nils-ost
Copy link

@nils-ost nils-ost commented Apr 5, 2022

What kind of change does this PR introduce?

  • bug fix
  • feature
  • docs update
  • tests/coverage improvement
  • refactoring
  • other

What is the related issue number (starting with #)

#1952

What is the current behavior?

Please refer to #1952

What is the new behavior (if this is a feature change)?

As proposed in my feature request I added the argument abs_index to the staticdir function. The default value is False, which does not change the behavior of staticdir as is. But if abs_index is set to True the given index -file is no longer searched relative to the Request-URI. Instead it is searched directly under the path given in dir argument.

Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

@nils-ost nils-ost changed the title #1952 added absolute index flag to staticdir Added absolute index flag to staticdir Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant