Fix explicitly releasing FileSessions #1834
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a test that captures the failure when explicit session locking is used with file sessions. The session tool adds a before_finalize hook to save the session, the FileSession class asserts that the session is locked before saving the session. The end result is if you use explicit locking with file sessions and release the lock yourself an AssertionError is raised when before_finalize runs.
Fix the AssertionError that is raised when using explicit locking with the FileSession storage class. The before_finalize handler from the SessionTool calls save() on the session, which asserts that the session is locked, which may not be the case when using explicit locking. If explicit locking is being used FileSession's _save() will now acquire the lock if the session is not already locked. Fixes cherrypy#1345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the related issue number (starting with
#)#1345
What is the current behavior? (You can also link to an open issue here)
#1345
What is the new behavior (if this is a feature change)?
Other information:
Checklist:
and description in grammatically correct, complete sentences