Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate cache on PATCH request #1796

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Invalidate cache on PATCH request #1796

wants to merge 2 commits into from

Conversation

ingoogni
Copy link
Contributor

What kind of change does this PR introduce?

  • bug fix
  • feature
  • docs update
  • tests/coverage improvement
  • refactoring
  • other

What is the related issue number (starting with #)
N.a.

What is the current behaviour? (You can also link to an open issue here)
On a PATCH request the related cached responses are not invalidated

What is the new behaviour (if this is a feature change)?
On a PATCH request the related cached responses will be invalidated

Other information:

Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

Invalidate appropriate cached response on PATCH request
Tests seem to cover the addition of cache invalidation on PATCH request. Only a small addition to a comment.
@jaraco jaraco changed the base branch from master to main March 23, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant