V2: Fix small hpopt bugs and add example notebook #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihchengli
reviewed
Apr 25, 2024
There was a problem hiding this comment.
Thanks for making this PR. There are two minor things you might consider adding to the notebook:
- Include metrics within the model (e.g.,
metric_list = [nn.metrics.RMSEMetric(), nn.metrics.MAEMetric()]) in the notebook. - Add the ASHAScheduler to the notebook, as we use it by default.
| @@ -242,6 +243,9 @@ def update_args_with_config(args: Namespace, config: dict) -> Namespace: | |||
| case "init_lr_ratio": | |||
| setattr(args, "init_lr", value * args.max_lr) | |||
|
|
|||
| case "batch_size" | "depth" | "ffn_num_layers" | "ffn_hidden_dim" | "message_hidden_dim": | |||
There was a problem hiding this comment.
This will be fixed in #873 and this line can be removed after that.
|
The test fails because the filename has changed. Changing the filename of "best_params.json" to "best_config.json" in test_hyperopt_quick within tests/unit/utils/test_save_load_mol.py can fix it. |
Co-authored-by: Shih-Cheng Li <scli@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an example hpopt notebook. Happy to take suggestion on the notebook.
Found some small bugs related to input type and saving hpopt results while working on the notebook. Fixed those.
Example / Current workflow
n/a
Bugfix / Desired workflow
n/a
Questions
n/a
Relevant issues
n/a
Checklist