New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hyperparameter predictorbase #832
Fix hyperparameter predictorbase #832
Conversation
Thanks for the PR! @hwpang are these test failures because the saved checkpoints include the hyperparameters which are now ignored in this PR? |
When I run pytest locally on the original code I get: 2 failed, 660 passed, 15 skipped, 560 warnings in 940.00s (0:15:39) My code produces: 17 failed, 645 passed, 15 skipped, 421 warnings in 930.48s (0:15:30)
Edit Edit 2 |
@hwpang could you review? Not sure which of these lines are actually required. Pretty sure we need to rebuild the checkpoint files with these |
Thanks for the PR! This seems fine to me. Could you run this script? The script will regenerate all the checkpoint files we use for tests. After you run the script, please commit those new checkpoint files and push to this PR. This will run the tests with the newly generated checkpoints to ensure that they are indeed correct and compatible. |
…' into fix_hyperparameter_predictorbase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR fixes warnings from lightning, caused by setting parameters.
(Also removes a duplicate line)
Example / Current workflow
Bugfix / Desired workflow
See PR