Relocate License Logic on Windows systems into Ruby

[jwdean]

Previous logic used PowerShell to call ruby.exe, with the ruby being an embedded string within the PowerShell script. That ruby used LicenseAcceptance::Acceptor to apply the license acceptance condition. This also used chef_install_dir to determine where Chef was located.

The new logic eliminates the embedded Ruby by determining if there is license acceptance before starting PowerShell to modify the command line of the post-action ChefClient execution. This now will use the --chef-license command line parameter to affect the license state. Instead of using chef_install_dir to determine where Chef is installed it will use the exec_command resource.

Description

There are two desired impacts of this change

1. Stylistically it is poor form to embed Ruby in PowerShell that is effectively called by Ruby. If there were tests for this code, it would be untestable.

2. The use of chef_install_dir is used for two non-congruent purposes in the cookbook:
   -- determines the directory where the PowerShell script to be run is located.
   

   chef_client_updater/providers/default.rb

   Line 309 in a709307

   Kernel.spawn("c:/windows/system32/schtasks.exe /F /RU SYSTEM /create /sc once /ST \"#{upgrade_start_time}\" /tn Chef_upgrade /tr \"powershell.exe -ExecutionPolicy Bypass \"#{chef_install_dir}\"/../chef_upgrade.ps1 2>&1 > #{chef_upgrade_log}\"")

   
   That location would (by default) be C:\OpsCode.

   -- determines where ruby.exe is located (in PowerShell).
   

   chef_client_updater/providers/default.rb

   Line 571 in a709307

   #{chef_install_dir}/embedded/bin/ruby.exe -e "

   
   The need this addresses is to allow the PowerShell script to be run from a directory other than that in which Chef is installed. This is a security requirement for us. While the more obvious change may have been to modify the behavior of the first case above, the, changing the second is a light touch that does should not change the current, expected behavior.

Issues Resolved

None

Check List

• [No] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
  I've been so far unsuccessful at setting up testing for community cookbooks outside of my own lab. Working on it still.
• [N/A] New functionality includes testing.
• [N/A] New functionality has been documented in the README if applicable
• [Yes] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

[phiggins]

This seems like a good change to me, but I can't tell if the CI failures are related to this PR.

[thsteven13]

TravisCI seems to be failing on this repo for about a year now with the same error. So i dont think it's related to this PR.

[phiggins]

Suggested change

	post_action = if (new_resource.post_install_action == 'exec') && (desired_version.major >= 15)
	"#{new_resource.exec_command} --chef-license #{license_provided}"
	elsif desired_version.major < '15'
	new_resource.exec_command
	else
	''
	end
	post_action = if new_resource.post_install_action != 'exec'
	''
	elsif desired_version.major >= 15
	"#{new_resource.exec_command} --chef-license #{license_provided}"
	else
	new_resource.exec_command
	end

I think this conditional needs to change to maintain the old behavior.

The whitespace is probably all wrong because I'm trying to do this in github's comment box.

[jwdean]

Updated. Thank you.