Fix python 3 stuff #9
Conversation
$ pip install tox
...
$ tox
...
py26: commands succeeded
py27: commands succeeded
ERROR: py32: InvocationError: /Users/marca/dev/git-repos/cheetah/.tox/py32/bin/pip install -U --no-deps /Users/marca/dev/git-repos/cheetah/.tox/dist/Cheetah-2.4.4.zip (see /Users/marca/dev/git-repos/cheetah/.tox/py32/log/py32-3.log)
ERROR: py33: InvocationError: /Users/marca/dev/git-repos/cheetah/.tox/py33/bin/pip install -U --no-deps /Users/marca/dev/git-repos/cheetah/.tox/dist/Cheetah-2.4.4.zip (see /Users/marca/dev/git-repos/cheetah/.tox/py33/log/py33-3.log)
ERROR: py34: InvocationError: /Users/marca/dev/git-repos/cheetah/.tox/py34/bin/pip install -U --no-deps /Users/marca/dev/git-repos/cheetah/.tox/dist/Cheetah-2.4.4.zip (see /Users/marca/dev/git-repos/cheetah/.tox/py34/log/py34-3.log)
pypy: commands succeeded
|
I'm not an admin, only a user of Cheetah, but I'm glad to see it get some attention. Moving to Python3 is on my to-do list and having Cheetah support that would make my life much easier. |
msabramo
force-pushed
the
fix_python_3_stuff
branch
from
370e822
to
a1eccef
Compare
|
Note: This fixes all of the issues fixed by #7 plus a few more. |
|
bump |
|
fwiw, we're maintaining a fork which adds python3 support (in v0.1.1) (but cuts out a ton of features we deemed unnecessary) here: https://github.com/Yelp/yelp_cheetah |
|
@asottile want to take over the github organization and help get some of this updated? |
|
@rtyler The fork is so far removed now that it's not properly cheetah anymore; people would have to do some good amount of work to port any existing cheetah project. |
|
@rtyler What's your relationship to cheetah now? |
@rtyler if nobody has stepped up — could it be me? I have been using Cheetah for ages. I must admit I don't know its internals and has to learn it. I cannot promise I could revive development but at least I am gonna try. |
|
This was applied at CheetahTemplate3/cheetah3@f60572d Thank you! |
Fix a few small things that don't work in Python 3. It still doesn't work in Python 3, but it's a tad closer and this is a small and easy PR to review.