Create non-conflicting template module names #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The genUniqueModuleName() implementation generated module name conflicts when rendering many templates in quick succession. The combination of poor time resolution of str(time.time()) due to the default string representation and too small value range for the random part resulted in this. Added a simple retry in case of conflicts. Fixes mysterious looking failures that look like this: File "cheetah_DynamicallyCompiledCheetahTemplate_1336479589_95_84044.py", line 58, in __init__ TypeError: super() argument 1 must be type, not None
|
Applied at CheetahTemplate3/cheetah3@a2aa277 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The genUniqueModuleName() implementation generated module name
conflicts when rendering many templates in quick succession.
The combination of poor time resolution of str(time.time()) due
to the default string representation and too small value range
for the random part resulted in this.
Added a simple retry in case of conflicts.
Fixes mysterious looking failures that look like this:
File "cheetah_DynamicallyCompiledCheetahTemplate_1336479589_95_84044.py", line 58, in init
TypeError: super() argument 1 must be type, not None