Re-enable quickfixes #690
Open
Re-enable quickfixes #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3e1590 fixed the metadata registration for markers. That also led to the module name in the marker attributes to no longer be named FooCheck, but just Foo. Therefore the marker resolution no longer matches, and the "Check" suffix needs to be removed there, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f3e1590 fixed the metadata registration for markers. That also led to the module name in the marker attributes to no longer be named FooCheck, but just Foo. Therefore the marker resolution no longer matches, and the "Check" suffix needs to be removed there, too.
Looks like this after the fix:
The light bulbs (and the actual quick fixes) were missing since above commit.