Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge-EM Tweaks #59

Merged
merged 3 commits into from
May 15, 2024
Merged

Merge-EM Tweaks #59

merged 3 commits into from
May 15, 2024

Conversation

mharradon
Copy link
Collaborator

Clean some things up, demonstrate naming convention for cache fields in SFuncs.

Copy link
Collaborator

@apfeffer apfeffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Michael,

All looks good, except that in Cat you've made original_range into __original_range. original_range is actually the user facing value, whereas range is internally calculated. So original_range should stay as is, I think, whereas range should become __range. A better solution would be to rename original_range with range, and range with __compiled_range.

@mharradon
Copy link
Collaborator Author

mharradon commented May 7, 2024

That's fine - I expected .range was user facing as many tests/algorithms refer to it rather than .original_range, so it seemed the de-facto interface.

My intent with non-dunderscored parameters is that they minimally define the SFunc input-output relation. It seems like deduplicated range serves that purpose better.

Copy link
Collaborator

@jcampolongo jcampolongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you mentioned, this is general cleanup (not really any tweaks) for readability, which is great.

@mharradon mharradon merged commit d75772d into merge-em May 15, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants